-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'className' customization #104
Comments
I see two primary use cases for CSS and themes:
For the first case, this is usually accomplished purely through stylesheet overrides and maybe a little bit of high-level scoping, but individual components are often left untouched. I have an issue open for this, since the multi-selection case currently doesn't handle themes very well. For the second case, I agree that it's currently not really possible to assign your own classnames to subcomponents of the typeahead, like the menu or the input. I'm working to expose the subcomponents so developers have full flexibility in customizing them, including adding classnames. Does that more or less capture the use cases you're thinking of? |
Yes, that covers all the use cases, and actually with the already implemented custom render and stylesheet overrides I've been able to get the required result (except codestyle guidelines for css). The only thing that this solution is looking more like a workaround when you implement custom rendering just to replace a class name. Expose the subcomponents will be definitely helpful... Thanks! |
As of v3.0.0 pretty much every subcomponent can either be rendered in a custom manner (vie eg: |
What do you think about class names customization by passing some kind of 'theme' or 'classNames' parameter to the component with all classes definition you want to override for the component? E.g.:
This way we can address many issued like maintain project naming guidelines, integrate different themes and bootstrap versions, sizes etc...
The text was updated successfully, but these errors were encountered: