Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings from React 15.5 #168

Closed
yedyharova opened this issue Apr 20, 2017 · 9 comments
Closed

Fix deprecation warnings from React 15.5 #168

yedyharova opened this issue Apr 20, 2017 · 9 comments

Comments

@yedyharova
Copy link

Feature requests - React.js 15.5.* support.

I use your great react-bootstrap-typeahead. So - it is awesome :-).

And now after React.js 15.5.4 was installed I got warnings:

  1. Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
  2. Portal: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

Do you plan to upgrade your code?
https://facebook.github.io/react/blog/

Thank you in advance for an answer.
Maybe I just need do something.

@ericgio
Copy link
Owner

ericgio commented Apr 20, 2017

Thanks for the report. Note that these are simply deprecation warnings in anticipation of React 16 and won't cause any errors... yet. Fixing these warnings is on my to-do list, I just need to get around to it :)

@ericgio ericgio changed the title Accessing PropTypes via the main React package is deprecated. Portal: React.createClass is deprecated. Fix deprecation warnings from React 15.5 Apr 20, 2017
@lunochkin
Copy link
Contributor

lunochkin commented May 3, 2017

@ericgio
Fixed deprecations for the module and updated some dependencies.
Though, there is the same problem with https://github.com/helior/react-highlighter/ dependency yet.
But I think the PR can be merged at the moment.

@BillOTei
Copy link

BillOTei commented Jun 6, 2017

@lunochkin don't get it, are the deprecations fixed? Still getting them on my side.

@MatthieuLemoine
Copy link

MatthieuLemoine commented Jun 7, 2017

@BillOTei Those changes are not released yet see #181

@BillOTei
Copy link

BillOTei commented Jun 7, 2017 via email

@lunochkin
Copy link
Contributor

It seems that now all dependencies are without such problem, so new release can be published.

@sotnikoff
Copy link

Installed today and still get the same errors

@ericgio
Copy link
Owner

ericgio commented Jun 10, 2017

Fixed in v1.4.0. Sorry for the delay.

@ericgio ericgio closed this as completed Jun 10, 2017
@sotnikoff
Copy link

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants