Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled options can be selected on Enter #304

Closed
hslojewski opened this issue Feb 12, 2018 · 3 comments
Closed

Disabled options can be selected on Enter #304

hslojewski opened this issue Feb 12, 2018 · 3 comments
Labels
bug

Comments

@hslojewski
Copy link

hslojewski commented Feb 12, 2018 •
edited

Hello, I understand how to use disabled options, and that disabled options cannot be selected through a mouse cursor. However, they're still "selectable" on keypress/on pressing Enter.
@ericgio
Copy link
Owner

ericgio commented Feb 12, 2018

You're right, thanks. I'll take a look.

@ericgio ericgio added the bug label Feb 12, 2018
@alasdairhurst
Copy link
Contributor

Seems like they should also not have hover styles too

ericgio added a commit that referenced this issue Feb 16, 2018
@ericgio
Prevent disabled options from being highlighted/selected (#304)
6071cca
@ericgio
Copy link
Owner

ericgio commented Feb 16, 2018

Fixed in v2.3.2

@ericgio ericgio closed this as completed Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ericgio @alasdairhurst @hslojewski