Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diacritics in non-Latin alphabet strings are not stripped #659

Closed
ianatha opened this issue Aug 11, 2021 · 1 comment
Closed

Diacritics in non-Latin alphabet strings are not stripped #659

ianatha opened this issue Aug 11, 2021 · 1 comment
Labels

Comments

@ianatha
Copy link

ianatha commented Aug 11, 2021

Version

5.2.0

Steps to reproduce

  1. Load up https://codesandbox.io/s/gracious-dust-70ygq?file=/src/index.js
  2. Type "μερα" (note no accent on lowercase epsilon)
  3. Note that option "Καλημέρα" is not displayed

Expected Behavior

"καλημερα" (charcodes: [954, 945, 955, 951, 956, 941, 961, 945])

should match

"καλημέρα" (charcodes [])

when stripDiactrics is true

Actual Behavior

"καλημερα" did not match "καλημέρα"

Suggestion

Using something like str.normalize("NFD").replace(/[\u0300-\u036f]/g, "") may work better than the current stripDiactrics, although it's not supported in Internet Explorer and WebView Android.

@ianatha ianatha added the bug label Aug 11, 2021
@ianatha ianatha changed the title Diacritics in non-latin-script strings are not striped Diacritics in non-Latin alphabet strings are not striped Aug 11, 2021
@ericgio ericgio changed the title Diacritics in non-Latin alphabet strings are not striped Diacritics in non-Latin alphabet strings are not stripped Sep 6, 2021
@ericgio
Copy link
Owner

ericgio commented Oct 11, 2021

Addressed in v6.0.0-alpha.1

@ericgio ericgio closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants