Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking typeahead rendered to shadow DOM hides menu #717

Closed
charlesroelli opened this issue May 19, 2022 · 4 comments
Closed

Clicking typeahead rendered to shadow DOM hides menu #717

charlesroelli opened this issue May 19, 2022 · 4 comments
Labels
bug

Comments

@charlesroelli
Copy link
Contributor

Version

react@17.0.2
react-dom@17.0.2
react-bootstrap-typeahead@6.0.0-alpha.11

Steps to reproduce

I tried to render the Typeahead to a shadow root and noticed this issue.

  1. Open https://codepen.io/forthadena/pen/jOZmzyX
  2. Click the typeahead.

Expected Behavior

The menu opens showing the list of options.

Actual Behavior

The menu briefly opens and then disappears.
@charlesroelli
Copy link
Contributor Author

I think it's a bug in useRootClose, see react-bootstrap/react-overlays#1004

@ericgio
Copy link
Owner

ericgio commented May 25, 2022

Thanks for following up and submitting the fix!

@charlesroelli
Copy link
Contributor Author

This should be fixed now in react-overlays@5.2.0.

charlesroelli pushed a commit to charlesroelli/react-bootstrap-typeahead that referenced this issue Jun 2, 2022
@scallywag
Upgrade react-overlay (ericgio#717)
37b7841
charlesroelli pushed a commit to charlesroelli/react-bootstrap-typeahead that referenced this issue Jun 2, 2022
@scallywag
Upgrade react-overlays (ericgio#717)
9ac08b5
@charlesroelli charlesroelli mentioned this issue Jun 2, 2022
Merged
ericgio pushed a commit that referenced this issue Jun 3, 2022
@charlesroelli @scallywag
Upgrade react-overlays (#717) (#721)
dfe6c5d 
Co-authored-by: scallywag <scallywag@users.noreply.github.com>
@ericgio
Copy link
Owner

ericgio commented Jun 3, 2022

Fixed in v6.0.0-rc.1

@ericgio ericgio closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericgio @charlesroelli