Criteria to decide whether to try to re-parameterize in FitCurves is bad (scale-dependent)

[jimmyland]

e.g. if units are such that user's error threshold is less than 1, the function will never try to re-parameterize. Based on the usage example (where error is 4.0), I think the intent would be preserved if you just set iterationError = error * 4.0;

bad code is here:

GraphicsGems/gems/FitCurves.c

Line 113 in 4d1d0a0

iterationError = error * error;

(and iterationError is used at line 146)

[erich666]

Thanks. I've attempted to contact the author, Phil Schneider, for his opinion.

[jimmyland]

Alternatively I could do a PR that exposes the error scale factor as a parameter? (and that line would then become iterationError = error * iterationErrorScaleFactor;?)

[erich666]

The good news is that Philip Schneider recently responded, so I'm hoping he'll look at the code soon and figure out what's the most sensible.

[erich666]

Pinged Philip.

[erich666]

Philip replied: "The suggested change is probably OK." So I've checked it in, and pointed the interested user at this issue for more details.