Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples should not mix with twitter.bootstrap.mvc4 package #66

Open
serra opened this issue Feb 1, 2013 · 1 comment
Open

Examples should not mix with twitter.bootstrap.mvc4 package #66

serra opened this issue Feb 1, 2013 · 1 comment
Milestone

Comments

@serra
Copy link
Contributor

serra commented Feb 1, 2013

I run most of my tests using the sample package, so I only just noticed that there is a packaging error - we can no longer simply add all files like here in App_Start. There are probably other places that have similar errors, but right now I don't have time to check it out (controllers? example routes?) so instead created this issue.

Before packaging and pushing to NuGet, It's probably best to do a test that installs the packages without the sample and check that everything compiles out-of-the-box.

@erichexter
Copy link
Owner

agreed

Eric Hexter

blog | http://Hex.LosTechies.com
info | http://www.linkedin.com/in/erichexter

On Fri, Feb 1, 2013 at 9:00 AM, Marijn van der Zee <notifications@github.com

wrote:

I run most of my tests using the sample package, so I only just noticed
that there is a packaging error - we can no longer simply add all files like
here in App_Starthttps://github.com/erichexter/twitter.bootstrap.mvc/blob/master/src/twitter-bootstrap-mvc.nuspec#L28.
There are probably other places that have similar errors, but right now I
don't have time to check it out (controllers? example routes?) so instead
created this issue.

Before packaging and pushing to NuGet, It's probably best to do a test
that installs the packages without the sample and check that everything
compiles out-of-the-box.


Reply to this email directly or view it on GitHubhttps://github.com//issues/66.

@erichexter erichexter added this to the V2 milestone Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants