-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of breadcrumbs #58
Conversation
Looks interesting, I will check this out later this week. Some points to consider:
|
Yes. please move to the helpers package and add a example and tests if Eric Hexter blog | http://Hex.LosTechies.com On Mon, Jan 28, 2013 at 5:05 AM, Marijn van der Zee <
|
@erichexter, why close this pull request - looks like a good idea that only needs some improvements? |
I asked to move them to a the helpers package and add a samples. So, I Eric Hexter blog | http://Hex.LosTechies.com On Tue, Jan 29, 2013 at 1:32 AM, Marijn van der Zee <
|
…e.Routes);` For erichexter#58, per @jensj comment.
@jensj - I have changed the install script in the sample package to insert the bootstrap support code before Quickest way for you to pick up these changes (from a git shell in your twitter.bootstrap.mvc repo with a clean working directory) is to do:
I forked from your |
@Serrra, very nice of you. I the reason why I put the breadcrubs together with navigation was that I though of it as a part of navigation. |
@jensj - consider reopening this pull request if you like the state of the code. |
I'll have a look during the weekend. Guess there will be a bunch of other ones to implement 😄 |
@serra Hmmm, not finding time to work on this project right now. Most probably I'll be busy the upcoming weeks so feel free to move forward in any way you find appropriate. |
OK, thanks for the status update. You can leave this pull request closed; I'll open a new one. |
I appreciate your pull request, will please submit this contributor agreement. http://sdrv.ms/13eMRXm this will help keep the project compliant with our open source license. |
Proposal for implementation of breadcrumbs.
Worth noticing is that in the sample project there is a need to change the install script to add routes in order for the named routes to show up in RouteData.
Nuget package works fine after swapping above mentioned lines...