This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the panningArea, just like Google is doing with the YouTube iOS app.
nsdevaraj
approved these changes
Dec 30, 2017
instructorjavascript
approved these changes
Sep 25, 2019
hyuko21
approved these changes
Oct 8, 2019
Paulophmp
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Okk |
ok |
gabeduckham
reviewed
Oct 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
@@ -638,6 +640,10 @@ - (void)panePanned:(UIPanGestureRecognizer *)gestureRecognizer | |||
} | |||
case UIGestureRecognizerStateChanged: { | |||
CGPoint panLocationInPaneView = [gestureRecognizer locationInView:self.paneView]; | |||
|
|||
// If you want to pan the view, the first touch needs to be contained in this area | |||
if (! CGRectContainsPoint(self.panningArea, self.paneStartLocation)) return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Else
IAmRC1
approved these changes
Jun 7, 2020
IAmRC1
approved these changes
Jun 7, 2020
genialkartik
approved these changes
Sep 30, 2020
dcs-soni
approved these changes
Apr 1, 2021
abdul-shajin
approved these changes
Apr 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
takumade
approved these changes
Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to pan the view, the first touch needs to be contained in the panningArea, just like Google is doing with the YouTube iOS app.