Merge pull request #18 from ericksonreyes/code-cleanup

Clean up some codes
ericksonreyes · Jun 18, 2019 · a9e318e · a9e318e
2 parents 25c61c5 + dde2652
commit a9e318e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/src/EricksonReyes/DomainDrivenDesign/Common/Mailer/Email.php b/src/EricksonReyes/DomainDrivenDesign/Common/Mailer/Email.php
@@ -69,7 +69,8 @@ public function __construct(
         EmailAddressInterface $sender,
         EmailAddressInterface $recipient,
         EmailBodyInterface $body
-    ) {
+    )
+    {
         $this->sender = $sender;
         $this->recipients[] = $recipient;
         $this->body = $body;

diff --git a/src/EricksonReyes/DomainDrivenDesign/Common/ValueObject/PersonName.php b/src/EricksonReyes/DomainDrivenDesign/Common/ValueObject/PersonName.php
@@ -34,7 +34,7 @@ class PersonName implements ValueObject, HasLength
     private $lastName;
 
     /**
-     * @var
+     * @var string
      */
     private $postNominals;
 

diff --git a/src/EricksonReyes/DomainDrivenDesign/Example/Domain/DomainEntityWasDeletedEvent.php b/src/EricksonReyes/DomainDrivenDesign/Example/Domain/DomainEntityWasDeletedEvent.php
@@ -80,6 +80,7 @@ public static function staticEntityType(): string
     /**
      * @param array $array
      * @return Event
+     * @throws \Exception
      */
     public static function fromArray(array $array): Event
     {

diff --git a/src/EricksonReyes/DomainDrivenDesign/Example/Domain/EventSourcedDomainEntity.php b/src/EricksonReyes/DomainDrivenDesign/Example/Domain/EventSourcedDomainEntity.php
@@ -76,10 +76,11 @@ public function delete(): void
             $this->additionalData()
         );
 
-        if ($this->eventNeverHappened(DomainEntityWasDeletedEvent::class)) {
-            if ($this->isTheFirstOccurrenceOfThis($event)) {
-                $this->storeAndReplayThis($event);
-            }
+        if (
+            $this->eventNeverHappened(DomainEntityWasDeletedEvent::class) &&
+            $this->isTheFirstOccurrenceOfThis($event)
+        ) {
+            $this->storeAndReplayThis($event);
         }
 
         if (!$this->isTheFirstOccurrenceOfThis($event)) {