Merge e965cf4 into 712a0a4

ericksonreyes · May 15, 2019 · ad972f1 · ad972f1
2 parents 712a0a4 + e965cf4
commit ad972f1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/spec/EricksonReyes/DomainDrivenDesign/Common/ValueObject/AddressSpec.php b/spec/EricksonReyes/DomainDrivenDesign/Common/ValueObject/AddressSpec.php
@@ -106,6 +106,13 @@ public function it_can_be_matched(Address $sameAddress)
     }
 
     public function it_can_be_mismatched(Address $aDifferentAddress)
+    {
+        $aDifferentAddress->street()->shouldBeCalled()->willReturn($this->street);
+        $aDifferentAddress->city()->shouldBeCalled()->willReturn($this->seeder->city);
+        $this->doesNotMatch($aDifferentAddress)->shouldReturn(true);
+    }
+
+    public function it_can_be_mismatched_by_country(Address $aDifferentAddress)
     {
         $aDifferentAddress->street()->shouldBeCalled()->willReturn($this->street);
         $aDifferentAddress->city()->shouldBeCalled()->willReturn($this->city);

diff --git a/spec/EricksonReyes/DomainDrivenDesign/Common/ValueObject/PersonNameSpec.php b/spec/EricksonReyes/DomainDrivenDesign/Common/ValueObject/PersonNameSpec.php
@@ -87,7 +87,7 @@ public function it_can_have_post_nominals()
         $this->withPostNominals($postNominals)->lastName()->shouldReturn($this->lastName);
     }
 
-    public function it_can_be_compared(PersonName $anotherPersonName)
+    public function it_can_be_compared(PersonName $anotherPersonName, PersonName $aDifferentPersonName)
     {
         $anotherPersonName->firstName()->shouldBeCalled()->willReturn($this->firstName);
         $anotherPersonName->lastName()->shouldBeCalled()->willReturn($this->lastName);
@@ -130,6 +130,12 @@ public function it_can_be_compared(PersonName $anotherPersonName)
         $sameNameButWithHonorific->postNominals()->shouldReturn($expectedPostNominals);
         $this->matches($sameNameButWithHonorific)->shouldReturn(true);
         $this->doesNotMatch($sameNameButWithHonorific)->shouldReturn(false);
+
+
+        $aDifferentPersonName->firstName()->shouldBeCalled()->willReturn($this->firstName);
+        $aDifferentPersonName->lastName()->shouldBeCalled()->willReturn($this->seeder->lastName);
+        $this->matches($aDifferentPersonName)->shouldReturn(false);
+        $this->doesNotMatch($aDifferentPersonName)->shouldReturn(true);
     }
 
     public function it_has_an_array_representation()