Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS with Pd>=0.55 #26

Closed
umlaeute opened this issue Jun 18, 2024 · 2 comments · Fixed by #27
Closed

FTBFS with Pd>=0.55 #26

umlaeute opened this issue Jun 18, 2024 · 2 comments · Fixed by #27

Comments

@umlaeute
Copy link
Contributor

With the recently released Pd-0.55, pd-lyonpotpourri no longer compiles (at least not for Pd64)

the reason is, that Pd is now stricter when it comes to types, and uses a static assert to ensure that the signal holder member in CLASS_MAINSIGNALIN is of type t_float.
Unfortunately, pd-lyonpotpourri uses type float in the following files:

  • adsr~.c
  • buffet~.c
  • bvplay~.c
  • channel~.c
  • chopper~.c
  • clean_selector~.c
  • click2bang~.c
  • click2float~.c
  • clickhold~.c
  • click~.c
  • convolver~.c
  • counter~.c
  • distortion~.c
  • dmach~.c
  • epluribus~.c
  • expflam~.c
  • flanjah~.c
  • granola~.c
  • granulesf~.c
  • granule~.c
  • kbuffer~.c
  • killdc~.c
  • magfreq_analysis~.c
  • markov~.c
  • mask~.c
  • npan~.c
  • oscil~.c
  • phasemod~.c
  • player~.c
  • pulser~.c
  • rtrig~.c
  • samm~.c
  • sigseq~.c
  • vdb~.c
  • vdp~.c
  • waveshape~.c

the solution is simply to switch to using t_float

@umlaeute
Copy link
Contributor Author

in general, you should use t_float instead of float whenever possible (which i think is everywhere except for specialized standalone functions like the penrose generators)

@umlaeute
Copy link
Contributor Author

related to ericlyon/pd-fftease#51

umlaeute added a commit to umlaeute/pd-lyonpotpourri that referenced this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant