Fixing newerVersion() #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function sometimes accepts version tags as newer versions even though it is not the case, the whole function has been rewritten to work as follows: - checks every number between dots one by one - if it is a number (or 'r' + number) and it is different, then it returns the comparison of the number - if it is the same number, then it ignores and iterate to the next number - if it is not a number but a commit hash, it returns true if is different. In all cases, commit hashes must be placed at the end of version tags so a complete return would work as intended A series of tests has been done on this function and can be run online, with comparison with the previous implementation: https://go.dev/play/p/QUm8zPl_Ngw Fixes ericm#31
ericm
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function sometimes accepts version tags as newer versions even though it is not the case, the whole function has been rewritten to work as follows:
A series of tests has been done on this function and can be run online, with comparison with the previous implementation:
https://go.dev/play/p/QUm8zPl_Ngw
Fixes #31