Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Improve selection/perf in conditional_join #1223

Closed
samukweku opened this issue Dec 15, 2022 · 0 comments · Fixed by #1224
Closed

[ENH] Improve selection/perf in conditional_join #1223

samukweku opened this issue Dec 15, 2022 · 0 comments · Fixed by #1224

Comments

@samukweku
Copy link
Collaborator

samukweku commented Dec 15, 2022 •
edited
Loading

  • Improve selection in conditional_join, such that only a single dataframe (left/right) is returned
  • simplify the numba implementation
  • add indicator parameter , similar to the indicator parameter in pd.merge
@samukweku samukweku mentioned this issue Dec 17, 2022
Merged
3 tasks
@samukweku samukweku changed the title [ENH] Improve selection in conditional_join [ENH] Improve selection/perf in conditional_join Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Improve conditional_join pyjanitor-devs/pyjanitor
1 participant
@samukweku