Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Cowboy depend on 0.6.0 instead of master #1

Merged
merged 1 commit into from Jun 13, 2012
Merged

Make Cowboy depend on 0.6.0 instead of master #1

merged 1 commit into from Jun 13, 2012

Conversation

essen
Copy link
Contributor

@essen essen commented Jun 13, 2012

I have breaking changes planned after 0.6.0 and I wouldn't want
this benchmark to stop working considering how important it is. :)

Also if that's OK with you I will include a few slides about it in
my OSCON talk in July.

I have breaking changes planned after 0.6.0 and I wouldn't want
this benchmark to stop working considering how important it is. :)
@ericmoritz
Copy link
Owner

Sure thing. Tonight I'm adding a benchmark for EventMachine and Twisted's websocket implementation. I'll rerun the Cowboy benchmark using version 0.6.0.

ericmoritz added a commit that referenced this pull request Jun 13, 2012
Make Cowboy depend on 0.6.0 instead of master
@ericmoritz ericmoritz merged commit 80b9ec9 into ericmoritz:master Jun 13, 2012
@ericmoritz
Copy link
Owner

You may want to look at the data for the Cowboy benchmark. 25% of the handshakes were more than 742ms. While the TCP connection didn't timeout, up to 2,500 of the connections may have had really slow handshakes. 5% of the connections had > 4sec handshakes.

Thanks what I get for tweeting at 3 in the morning :)

@essen
Copy link
Contributor Author

essen commented Jun 13, 2012

If it's with 0.6, I know where the problem lies, it's already fixed in my local code.-- Envoyé depuis mon HP Pre3Le 13 juin 2012 19:27, ericmoritz reply@reply.github.com a écrit : You may want to look at the data for the Cowboy benchmark. 25% of the handshakes were more than 742ms. While the TCP connection didn't timeout, up to 2,500 of the connections may have had really slow handshakes. 5% of the connections had > 4sec handshakes.

Thanks what I get for tweeting at 3 in the morning :)

Reply to this email directly or view it on GitHub:
#1 (comment)

@ericmoritz
Copy link
Owner

This was based on 'master' as of last night around 1 or 2 am EST. I destroyed the AWS instances so I can't say for sure. I'll let you know what it looks like on 0.6.0 tonight.

@essen
Copy link
Contributor Author

essen commented Jun 13, 2012

Master is 0.6 :)-- Envoyé depuis mon HP Pre3Le 13 juin 2012 21:33, ericmoritz reply@reply.github.com a écrit : This was based on 'master' as of last night around 1 or 2 am EST. I destroyed the AWS instances so I can't say for sure. I'll let you know what it looks like on 0.6.0 tonight.

Reply to this email directly or view it on GitHub:
#1 (comment)

@ericmoritz
Copy link
Owner

So, yes it was done on 0.6 then. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants