Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make Cowboy depend on 0.6.0 instead of master #1

Merged
merged 1 commit into from Jun 13, 2012

Conversation

Projects
None yet
2 participants
Contributor

essen commented Jun 13, 2012

I have breaking changes planned after 0.6.0 and I wouldn't want
this benchmark to stop working considering how important it is. :)

Also if that's OK with you I will include a few slides about it in
my OSCON talk in July.

@essen essen Make Cowboy depend on 0.6.0 instead of master
I have breaking changes planned after 0.6.0 and I wouldn't want
this benchmark to stop working considering how important it is. :)
f435a56
Owner

ericmoritz commented Jun 13, 2012

Sure thing. Tonight I'm adding a benchmark for EventMachine and Twisted's websocket implementation. I'll rerun the Cowboy benchmark using version 0.6.0.

@ericmoritz ericmoritz added a commit that referenced this pull request Jun 13, 2012

@ericmoritz ericmoritz Merge pull request #1 from essen/patch-1
Make Cowboy depend on 0.6.0 instead of master
80b9ec9

@ericmoritz ericmoritz merged commit 80b9ec9 into ericmoritz:master Jun 13, 2012

Owner

ericmoritz commented Jun 13, 2012

You may want to look at the data for the Cowboy benchmark. 25% of the handshakes were more than 742ms. While the TCP connection didn't timeout, up to 2,500 of the connections may have had really slow handshakes. 5% of the connections had > 4sec handshakes.

Thanks what I get for tweeting at 3 in the morning :)

Contributor

essen commented Jun 13, 2012

If it's with 0.6, I know where the problem lies, it's already fixed in my local code.-- Envoyé depuis mon HP Pre3Le 13 juin 2012 19:27, ericmoritz reply@reply.github.com a écrit : You may want to look at the data for the Cowboy benchmark. 25% of the handshakes were more than 742ms. While the TCP connection didn't timeout, up to 2,500 of the connections may have had really slow handshakes. 5% of the connections had > 4sec handshakes.

Thanks what I get for tweeting at 3 in the morning :)

Reply to this email directly or view it on GitHub:
#1 (comment)

Owner

ericmoritz commented Jun 13, 2012

This was based on 'master' as of last night around 1 or 2 am EST. I destroyed the AWS instances so I can't say for sure. I'll let you know what it looks like on 0.6.0 tonight.

Contributor

essen commented Jun 13, 2012

Master is 0.6 :)-- Envoyé depuis mon HP Pre3Le 13 juin 2012 21:33, ericmoritz reply@reply.github.com a écrit : This was based on 'master' as of last night around 1 or 2 am EST. I destroyed the AWS instances so I can't say for sure. I'll let you know what it looks like on 0.6.0 tonight.

Reply to this email directly or view it on GitHub:
#1 (comment)

Owner

ericmoritz commented Jun 13, 2012

So, yes it was done on 0.6 then. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment