Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constexpr to advance, distance, next, and prev #256

Closed
ericniebler opened this issue Nov 9, 2016 · 3 comments
Closed

Add constexpr to advance, distance, next, and prev #256

ericniebler opened this issue Nov 9, 2016 · 3 comments

Comments

@ericniebler
Copy link
Owner

Also common_iterator(?).

@ericniebler ericniebler changed the title Add constexpr to advance, distance, next, prev, and distance Add constexpr to advance, distance, next, and prev Nov 12, 2016
@CaseyCarter
Copy link
Collaborator

CaseyCarter commented Nov 13, 2016

My review notes were more along the lines of "Add constexpr to those things that are constexpr in the WD, notably advance, distance, next, prev." reverse_iterator and move_iterator are also heavily constexpr in the WD; there was a strong consistency argument that common_iterator and counted_iterator should be as well.

@ericniebler
Copy link
Owner Author

With the caveat that we have to be careful with common_iterator to not disallow a variant-like implementation.

@CaseyCarter
Copy link
Collaborator

Resolved in P0579.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants