Apply P0547R2 #456
Merged
Apply P0547R2 #456
+72
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to fix merge conflicts. |
CaseyCarter
commented
Jul 18, 2017
concepts.tex
Outdated
| \end{itemdecl} | ||
|
|
||
| \begin{itemdescr} | ||
| \pnum | ||
| <<<<<<< 142646fd53fd433ab929d28f9799c45bbaa4bb57 |
There was a problem hiding this comment.
Great failure. Maybe you should save the changes before committing?
CaseyCarter
force-pushed
the
apply_547
branch
2 times, most recently
from
8ca7492
to
0b2ceb4
Compare
...and again. |
ericniebler
requested changes
Jul 18, 2017
|
|
||
| \pnum | ||
| There need not be any subsumption relationship between \tcode{Assignable<T, U>} | ||
| and \tcode{is_lvalue_reference<T>::value}. |
There was a problem hiding this comment.
You need to wrap is_lvalue_reference<T>::value.
There was a problem hiding this comment.
I plan to handle poor line wrapping in a separate pass after incorporating all of the PRs. I've added a note to #455 to be sure to check these two occurrences specifically.
| \item The expression \tcode{\&t} is non-modifying. | ||
| \end{itemize} | ||
| There need not be any subsumption relationship between \tcode{Destructible<T>} | ||
| and \tcode{is_nothrow_destructible<T>::value}. |
There was a problem hiding this comment.
is_nothrow_destructible<T>::value needs to be wrapped.
concepts.tex
Outdated
|
|
||
| \item If \tcode{T} is not \tcode{const}, \tcode{rv}'s resulting state is valid | ||
| but unspecified~(\cxxref{lib.types.movedfrom}). |
There was a problem hiding this comment.
You forgot "; otherwise, it is unchanged."
|
Content fix applied (saving pure presentation fixes for later). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70, #229, #300, #301, #310, #313, #339, #381, #382, #387, #399.