Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic.js and implement relayd for bridge configs #501

Merged
merged 6 commits into from Apr 3, 2016

Conversation

lantis1008
Copy link
Contributor

  • Basic.js should now behave correctly under all configuration types.
  • Bridge configs are now implemented using relayd. Router IP should be DIFFERENT to AP subnet. I haven't changed the translation files to reflect this yet.

Please thoroughly test this patch, i've done my best to make sure it is ready.


uci.set("dhcp", "lan", "ignore", "1");

uci.set("firewall", "lan", "network", "lan wwan");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is no good. should be something like

uci.set("firewall", "@zone[0]", "network", "lan wwan");

Need to test whether @zone[0] works all the time, which i suspect it doesn't. May need a better way of identifying the correct config section.

@lantis1008 lantis1008 mentioned this pull request Mar 22, 2016
@lantis1008
Copy link
Contributor Author

Fixes #504 . Still needs fixing on the firewall script before it is merged. Apologies.

@lantis1008
Copy link
Contributor Author

Firewall rules should now work properly.

@ericpaulbishop
Copy link
Owner

I've tested this and, I couldn't find any issues. Good job!

I have this nagging suspicion that I've missed something, given how complex this is, and I'm not sure I want to do a release quite yet (though we're overdue for one), but this looks very, very good. Thank you.

@ericpaulbishop ericpaulbishop merged commit 5ac311c into ericpaulbishop:master Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants