Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Samba share access #680

Merged
merged 5 commits into from Nov 12, 2017

Conversation

lantis1008
Copy link
Contributor

  • Revert removal of "valid users" option
    This was not tested thoroughly enough by me. Causes any valid user credentials to gain access to ALL shares, despite what access restrictions are in place
  • Change samba guest account to "nobody" from "root"
    On Gargoyle it probably does not matter, but this is more conventional. If nobody account was compromised it has no valid login anyway
  • Add guest to valid users when guest access is selected
    This seems to be required to work properly when the "valid users" option is reinstated.

@ericpaulbishop ericpaulbishop merged commit 866348a into ericpaulbishop:master Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants