Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Xiaomi Mi Router 3G #786

Merged
merged 2 commits into from Jan 24, 2019
Merged

Add support for Xiaomi Mi Router 3G #786

merged 2 commits into from Jan 24, 2019

Conversation

naseef
Copy link
Contributor

@naseef naseef commented Jan 21, 2019

No description provided.

lantis1008
lantis1008 suggested changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@lantis1008 lantis1008 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see changes suggested. Please check these yourself as i have not taken into account any dependencies when making these code changes. Only what i saw.

With these changes, as long as it compiles ok, i'll be happy to merge it.

PS. This new beta feature with github to suggest code changes is definitely a bit broken. Definitely check yourself locally.

targets/ramips/profiles/mt7621/config Outdated Show resolved Hide resolved
targets/ramips/profiles/mt7621/config Outdated Show resolved Hide resolved
targets/ramips/profiles/mt7621/config Outdated Show resolved Hide resolved
targets/ramips/profiles/mt7621/config Outdated Show resolved Hide resolved
targets/ramips/profiles/mt7621/config Show resolved Hide resolved
targets/ramips/profiles/mt7621/config Outdated Show resolved Hide resolved
targets/ramips/profiles/mt7621/config Outdated Show resolved Hide resolved
targets/ramips/profiles/mt7621/config Outdated Show resolved Hide resolved
targets/ramips/profiles/mt7621/config Show resolved Hide resolved
targets/ramips/profiles/mt7621/config Outdated Show resolved Hide resolved
@lantis1008 @naseef
Apply suggestions from code review
4252386 
Co-Authored-By: naseef <naseefkm@gmail.com>
@naseef
Copy link
Contributor Author

naseef commented Jan 22, 2019

Compiles ok. Flashed successfully.

@obsy
Copy link
Contributor

obsy commented Jan 23, 2019

@lantis1008: little OT: maybe we should transfer all common options to another file, say, "common" - like CONFIG_CLEAN_IPKG_PARTIAL=y, CONFIG_BUILD_PATENTED=y, CONFIG_PACKAGE_plugin-gargoyle-usb-printer = m etc, and combine it into one .config before building the image for target.

@lantis1008
Copy link
Contributor

lantis1008 commented Jan 24, 2019 •
edited

@obsy we could try using diffconfig rather than these full config styles? This would shrink the files significantly and make them easier to update
For example, this config would turn into

CONFIG_TARGET_ramips=y
CONFIG_TARGET_ramips_mt7621=y
CONFIG_TARGET_ramips_mt7621_Default=y
CONFIG_BUSYBOX_CUSTOM=y
CONFIG_BUILD_PATENTED=y
CONFIG_BUSYBOX_CONFIG_ARPING=y
CONFIG_CLEAN_IPKG_PARTIAL=y
CONFIG_DRIVER_11AC_SUPPORT=y
CONFIG_DRIVER_11N_SUPPORT=y
CONFIG_DRIVER_11W_SUPPORT=y
CONFIG_LIBCURL_COOKIES=y
CONFIG_LIBCURL_FILE=y
CONFIG_LIBCURL_FTP=y
CONFIG_LIBCURL_HTTP=y
CONFIG_LIBCURL_NO_SMB="!"
CONFIG_LIBCURL_OPENSSL=y
CONFIG_LIBCURL_PROXY=y
CONFIG_OPENSSL_WITH_DEPRECATED=y
CONFIG_OPENSSL_WITH_EC=y
CONFIG_OPENSSL_WITH_NPN=y
CONFIG_OPENSSL_WITH_PSK=y
CONFIG_OPENSSL_WITH_SRP=y
CONFIG_OPENVPN_openssl_ENABLE_DEF_AUTH=y
CONFIG_OPENVPN_openssl_ENABLE_FRAGMENT=y
CONFIG_OPENVPN_openssl_ENABLE_HTTP=y
CONFIG_OPENVPN_openssl_ENABLE_LZ4=y
CONFIG_OPENVPN_openssl_ENABLE_LZO=y
CONFIG_OPENVPN_openssl_ENABLE_MULTIHOME=y
CONFIG_OPENVPN_openssl_ENABLE_PF=y
CONFIG_OPENVPN_openssl_ENABLE_PORT_SHARE=y
CONFIG_OPENVPN_openssl_ENABLE_SERVER=y
CONFIG_OPENVPN_openssl_ENABLE_SMALL=y
CONFIG_OPENVPN_openssl_ENABLE_SOCKS=y
CONFIG_PACKAGE_MAC80211_DEBUGFS=y
CONFIG_PACKAGE_MAC80211_MESH=y
CONFIG_PACKAGE_SAMBA_MAX_DEBUG_LEVEL=-1
CONFIG_PACKAGE_badblocks=y
CONFIG_PACKAGE_blkid=y
CONFIG_PACKAGE_block-mount=y
CONFIG_PACKAGE_bwmon-gargoyle=y
CONFIG_PACKAGE_ca-bundle=m
CONFIG_PACKAGE_chat=y
CONFIG_PACKAGE_comgt=y
CONFIG_PACKAGE_comgt-ncm=y
CONFIG_PACKAGE_curl=m
CONFIG_PACKAGE_ddns-gargoyle=y
CONFIG_PACKAGE_disktype=y
CONFIG_PACKAGE_e2fsprogs=y
CONFIG_PACKAGE_ebtables=y
CONFIG_PACKAGE_etherwake=y
CONFIG_PACKAGE_ewget=y
CONFIG_PACKAGE_fdisk=y
CONFIG_PACKAGE_gargoyle=y
CONFIG_PACKAGE_gargoyle-firewall-util=y
CONFIG_PACKAGE_gargoyle-i18n=y
CONFIG_PACKAGE_gargoyle-ip-query=y
CONFIG_PACKAGE_gargoyle-mjpg-streamer=m
CONFIG_PACKAGE_gargoyle-tor=m
CONFIG_PACKAGE_gpkg=y
CONFIG_PACKAGE_haserl-i18n=y
CONFIG_PACKAGE_hostapd-common=y
CONFIG_PACKAGE_ip-tiny=y
CONFIG_PACKAGE_ipset=m
CONFIG_PACKAGE_iptables-mod-bandwidth=y
CONFIG_PACKAGE_iptables-mod-conntrack-extra=y
CONFIG_PACKAGE_iptables-mod-extra=y
CONFIG_PACKAGE_iptables-mod-filter=y
CONFIG_PACKAGE_iptables-mod-imq=y
CONFIG_PACKAGE_iptables-mod-ipopt=y
CONFIG_PACKAGE_iptables-mod-iprange=y
CONFIG_PACKAGE_iptables-mod-nat-extra=y
CONFIG_PACKAGE_iptables-mod-timerange=y
CONFIG_PACKAGE_iptables-mod-webmon=y
CONFIG_PACKAGE_iptables-mod-weburl=y
CONFIG_PACKAGE_iw=y
CONFIG_PACKAGE_iwinfo=y
CONFIG_PACKAGE_kmod-cfg80211=y
CONFIG_PACKAGE_kmod-crypto-aead=y
CONFIG_PACKAGE_kmod-crypto-cbc=y
CONFIG_PACKAGE_kmod-crypto-crc32c=y
CONFIG_PACKAGE_kmod-crypto-cts=y
CONFIG_PACKAGE_kmod-crypto-des=y
CONFIG_PACKAGE_kmod-crypto-ecb=y
CONFIG_PACKAGE_kmod-crypto-hash=y
CONFIG_PACKAGE_kmod-crypto-hmac=y
CONFIG_PACKAGE_kmod-crypto-manager=y
CONFIG_PACKAGE_kmod-crypto-md5=y
CONFIG_PACKAGE_kmod-crypto-null=y
CONFIG_PACKAGE_kmod-crypto-pcompress=y
CONFIG_PACKAGE_kmod-crypto-sha1=y
CONFIG_PACKAGE_kmod-dma-buf=m
CONFIG_PACKAGE_kmod-dnsresolver=y
CONFIG_PACKAGE_kmod-ebtables=y
CONFIG_PACKAGE_kmod-ebtables-ipv4=y
CONFIG_PACKAGE_kmod-fs-exportfs=y
CONFIG_PACKAGE_kmod-fs-ext4=y
CONFIG_PACKAGE_kmod-fs-hfsplus=y
CONFIG_PACKAGE_kmod-fs-msdos=y
CONFIG_PACKAGE_kmod-fs-nfs=y
CONFIG_PACKAGE_kmod-fs-nfs-common=y
CONFIG_PACKAGE_kmod-fs-nfs-common-rpcsec=y
CONFIG_PACKAGE_kmod-fs-nfsd=y
CONFIG_PACKAGE_kmod-fs-vfat=y
CONFIG_PACKAGE_kmod-fuse=y
CONFIG_PACKAGE_kmod-gre=y
CONFIG_PACKAGE_kmod-input-core=m
CONFIG_PACKAGE_kmod-ipt-bandwidth=y
CONFIG_PACKAGE_kmod-ipt-conntrack-extra=y
CONFIG_PACKAGE_kmod-ipt-extra=y
CONFIG_PACKAGE_kmod-ipt-filter=y
CONFIG_PACKAGE_kmod-ipt-imq=y
CONFIG_PACKAGE_kmod-ipt-ipopt=y
CONFIG_PACKAGE_kmod-ipt-iprange=y
CONFIG_PACKAGE_kmod-ipt-ipset=m
CONFIG_PACKAGE_kmod-ipt-nat-extra=y
CONFIG_PACKAGE_kmod-ipt-timerange=y
CONFIG_PACKAGE_kmod-ipt-webmon=y
CONFIG_PACKAGE_kmod-ipt-weburl=y
CONFIG_PACKAGE_kmod-iptunnel=y
CONFIG_PACKAGE_kmod-lib-crc16=y
CONFIG_PACKAGE_kmod-lib-textsearch=y
CONFIG_PACKAGE_kmod-mac80211=y
CONFIG_PACKAGE_kmod-mii=y
CONFIG_PACKAGE_kmod-mppe=m
CONFIG_PACKAGE_kmod-mt76-core=y
CONFIG_PACKAGE_kmod-mt7603=y
CONFIG_PACKAGE_kmod-mt76x02-common=y
CONFIG_PACKAGE_kmod-mt76x2=y
CONFIG_PACKAGE_kmod-mt76x2-common=y
CONFIG_PACKAGE_kmod-nf-nathelper=y
CONFIG_PACKAGE_kmod-nf-nathelper-extra=y
CONFIG_PACKAGE_kmod-nfnetlink=m
CONFIG_PACKAGE_kmod-nls-cp1250=y
CONFIG_PACKAGE_kmod-nls-cp1251=y
CONFIG_PACKAGE_kmod-nls-cp437=y
CONFIG_PACKAGE_kmod-nls-cp775=y
CONFIG_PACKAGE_kmod-nls-cp850=y
CONFIG_PACKAGE_kmod-nls-cp852=y
CONFIG_PACKAGE_kmod-nls-cp866=y
CONFIG_PACKAGE_kmod-nls-iso8859-1=y
CONFIG_PACKAGE_kmod-nls-iso8859-13=y
CONFIG_PACKAGE_kmod-nls-iso8859-15=y
CONFIG_PACKAGE_kmod-nls-iso8859-2=y
CONFIG_PACKAGE_kmod-nls-koi8r=y
CONFIG_PACKAGE_kmod-nls-utf8=y
CONFIG_PACKAGE_kmod-pptp=y
CONFIG_PACKAGE_kmod-sched=y
CONFIG_PACKAGE_kmod-sched-core=y
CONFIG_PACKAGE_kmod-scsi-core=y
CONFIG_PACKAGE_kmod-tun=y
CONFIG_PACKAGE_kmod-usb-acm=y
CONFIG_PACKAGE_kmod-usb-ehci=y
CONFIG_PACKAGE_kmod-usb-net=y
CONFIG_PACKAGE_kmod-usb-net-cdc-ether=y
CONFIG_PACKAGE_kmod-usb-net-cdc-mbim=y
CONFIG_PACKAGE_kmod-usb-net-cdc-ncm=y
CONFIG_PACKAGE_kmod-usb-net-huawei-cdc-ncm=y
CONFIG_PACKAGE_kmod-usb-net-qmi-wwan=y
CONFIG_PACKAGE_kmod-usb-net-rndis=y
CONFIG_PACKAGE_kmod-usb-net-sierrawireless=y
CONFIG_PACKAGE_kmod-usb-printer=m
CONFIG_PACKAGE_kmod-usb-serial=y
CONFIG_PACKAGE_kmod-usb-serial-option=y
CONFIG_PACKAGE_kmod-usb-serial-qualcomm=y
CONFIG_PACKAGE_kmod-usb-serial-sierrawireless=y
CONFIG_PACKAGE_kmod-usb-serial-wwan=y
CONFIG_PACKAGE_kmod-usb-storage=y
CONFIG_PACKAGE_kmod-usb-storage-extras=y
CONFIG_PACKAGE_kmod-usb-storage-uas=y
CONFIG_PACKAGE_kmod-usb-wdm=y
CONFIG_PACKAGE_kmod-usb2=y
CONFIG_PACKAGE_kmod-video-core=m
CONFIG_PACKAGE_kmod-video-gspca-core=m
CONFIG_PACKAGE_kmod-video-gspca-ov534=m
CONFIG_PACKAGE_kmod-video-gspca-zc3xx=m
CONFIG_PACKAGE_kmod-video-uvc=m
CONFIG_PACKAGE_kmod-video-videobuf2=m
CONFIG_PACKAGE_libbbtargz=y
CONFIG_PACKAGE_libblkid=y
CONFIG_PACKAGE_libbz2=m
CONFIG_PACKAGE_libcap=m
CONFIG_PACKAGE_libcomerr=y
CONFIG_PACKAGE_libcurl=m
CONFIG_PACKAGE_libericstools=y
CONFIG_PACKAGE_libevent2=y
CONFIG_PACKAGE_libexif=m
CONFIG_PACKAGE_libext2fs=y
CONFIG_PACKAGE_libfdisk=y
CONFIG_PACKAGE_libffmpeg-audio-dec=m
CONFIG_PACKAGE_libflac=m
CONFIG_PACKAGE_libid3tag=m
CONFIG_PACKAGE_libipset=m
CONFIG_PACKAGE_libiptbwctl=y
CONFIG_PACKAGE_libiwinfo=y
CONFIG_PACKAGE_libjpeg=m
CONFIG_PACKAGE_liblzo=y
CONFIG_PACKAGE_libmnl=m
CONFIG_PACKAGE_libncurses=y
CONFIG_PACKAGE_libogg=m
CONFIG_PACKAGE_libopenssl=y
CONFIG_PACKAGE_librpc=y
CONFIG_PACKAGE_librt=y
CONFIG_PACKAGE_libsmartcols=y
CONFIG_PACKAGE_libsqlite3=m
CONFIG_PACKAGE_libss=y
CONFIG_PACKAGE_libusb-1.0=y
CONFIG_PACKAGE_libustream-openssl=y
CONFIG_PACKAGE_libuuid=y
CONFIG_PACKAGE_libvorbis=m
CONFIG_PACKAGE_libwrap=y
CONFIG_PACKAGE_minidlna=m
CONFIG_PACKAGE_miniupnpd=y
CONFIG_PACKAGE_msmtp=m
CONFIG_PACKAGE_msmtp-mta=m
CONFIG_PACKAGE_msmtp-nossl=m
CONFIG_PACKAGE_nfs-kernel-server=y
CONFIG_PACKAGE_nfs-kernel-server-utils=y
CONFIG_PACKAGE_nfs-utils=y
CONFIG_PACKAGE_ntfs-3g=y
CONFIG_PACKAGE_obfsproxy=m
CONFIG_PACKAGE_openssl-util=y
CONFIG_PACKAGE_openvpn-easy-rsa=y
CONFIG_PACKAGE_openvpn-openssl=y
CONFIG_PACKAGE_p910nd=m
CONFIG_PACKAGE_plugin-gargoyle-adblock=m
CONFIG_PACKAGE_plugin-gargoyle-ddns=y
CONFIG_PACKAGE_plugin-gargoyle-ddns-cloudflare=m
CONFIG_PACKAGE_plugin-gargoyle-email-notifications=m
CONFIG_PACKAGE_plugin-gargoyle-email-notifications-nossl=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-Arabic-AR=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-English-EN=y
CONFIG_PACKAGE_plugin-gargoyle-i18n-French-FR=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-German-DE=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-Norwegian-NO=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-Polish-PL=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-Portuguese-BR=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-Russian-RU=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-SimplifiedChinese-ZH-CN=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-Slovak-SK=m
CONFIG_PACKAGE_plugin-gargoyle-i18n-Spanish-ES=m
CONFIG_PACKAGE_plugin-gargoyle-initd=m
CONFIG_PACKAGE_plugin-gargoyle-logread=m
CONFIG_PACKAGE_plugin-gargoyle-minidlna=m
CONFIG_PACKAGE_plugin-gargoyle-openvpn=y
CONFIG_PACKAGE_plugin-gargoyle-ping-watchdog=m
CONFIG_PACKAGE_plugin-gargoyle-pptp=m
CONFIG_PACKAGE_plugin-gargoyle-qos=y
CONFIG_PACKAGE_plugin-gargoyle-spectrum-analyser=m
CONFIG_PACKAGE_plugin-gargoyle-spectrum-analyser-minimal=m
CONFIG_PACKAGE_plugin-gargoyle-theme-Gargoyle-Modern=m
CONFIG_PACKAGE_plugin-gargoyle-theme-by-matei=m
CONFIG_PACKAGE_plugin-gargoyle-theme-dark-one=m
CONFIG_PACKAGE_plugin-gargoyle-theme-demantoid=m
CONFIG_PACKAGE_plugin-gargoyle-theme-flat-blue=m
CONFIG_PACKAGE_plugin-gargoyle-theme-green=m
CONFIG_PACKAGE_plugin-gargoyle-theme-horchata=m
CONFIG_PACKAGE_plugin-gargoyle-theme-light=m
CONFIG_PACKAGE_plugin-gargoyle-theme-xeye=m
CONFIG_PACKAGE_plugin-gargoyle-tor=m
CONFIG_PACKAGE_plugin-gargoyle-upnp=y
CONFIG_PACKAGE_plugin-gargoyle-usb-printer=m
CONFIG_PACKAGE_plugin-gargoyle-usb-storage-full=y
CONFIG_PACKAGE_plugin-gargoyle-usb-storage-noshare=y
CONFIG_PACKAGE_plugin-gargoyle-webcam=m
CONFIG_PACKAGE_plugin-gargoyle-webshell=m
CONFIG_PACKAGE_plugin-gargoyle-wifi-schedule=m
CONFIG_PACKAGE_plugin-gargoyle-wol=y
CONFIG_PACKAGE_portmap=y
CONFIG_PACKAGE_ppp-mod-pptp=m
CONFIG_PACKAGE_qos-gargoyle=y
CONFIG_PACKAGE_resolveip=m
CONFIG_PACKAGE_samba36-server=y
CONFIG_PACKAGE_share-users=y
CONFIG_PACKAGE_swap-utils=y
CONFIG_PACKAGE_tc=y
CONFIG_PACKAGE_terminfo=y
CONFIG_PACKAGE_uboot-envtools=y
CONFIG_PACKAGE_uhttpd=y
CONFIG_PACKAGE_umbim=y
CONFIG_PACKAGE_uqmi=y
CONFIG_PACKAGE_usb-modeswitch=y
CONFIG_PACKAGE_vsftpd=y
CONFIG_PACKAGE_webmon-gargoyle=y
CONFIG_PACKAGE_wireless-regdb=y
CONFIG_PACKAGE_wpad-mini=y
CONFIG_PACKAGE_wwan=y
CONFIG_PACKAGE_zip=y
CONFIG_PACKAGE_zlib=m
CONFIG_WPA_MSG_MIN_PRIORITY=3

@ericpaulbishop ericpaulbishop merged commit 4252386 into ericpaulbishop:base_on_openwrt_remerge Jan 24, 2019
@lantis1008
Copy link
Contributor

I have merged this with additional changes to add ARPING utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantis1008 lantis1008 lantis1008 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@naseef @obsy @lantis1008 @ericpaulbishop