Handle devices with wan_dev network section #810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@obsy can you please check this solution.
Reference:
Couple of things i'm not sure on, and would be good if you could test/confirm:
wan_dev
sections if we delete the mainwan
section. E.g. lines 154 and 160 (and others). If thewan_dev
section causes no issues when it is present, then we will leave it. Definitely concerned about the implications when using wireless or usb protocols for wangargoyle_header_footer
also needs updating (line 945) although it will usually work without it anyway as the mac is sourced directly from the interface. But would be good to add as an extra check. Can you please confirm it works ok as it is, and your opinion on whether it should be modified (i think yes)?lan_dev
. Do you foresee anytime we need to do this?