Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deprecated SDPX identifiers #4

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Conversation

ericphanson
Copy link
Owner

Without these, things like is_osi_approved("LGPL-3.0") returns false, which is very misleading, since it is OSI approved, and the OSI website shows "LGPL-3.0" as the SDPX identifier for the license (https://opensource.org/licenses/alphabetical). It just happens to be deprecated as an SDPX identifier (they want you to use "LGPL-3.0-only" or "LGPL-3.0-or-later" instead, but when it's ambiguous, licensecheck returns "LGPL-3.0").

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #4 (7ff2668) into main (23ce74b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         2    +1     
  Lines            5        35   +30     
=========================================
+ Hits             5        35   +30     
Impacted Files Coverage Δ
src/LicenseCheck.jl 100.00% <100.00%> (ø)
src/find_licenses.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cbc6f...7ff2668. Read the comment docs.

@ericphanson ericphanson merged commit d1bc603 into main Feb 12, 2021
@ericphanson ericphanson deleted the eph/more_osi_licenses branch February 12, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant