-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to Comonicon 0.11 #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cool! Thank you 😃 |
oh 0.11 only support 1.6+ btw |
auto-merge was automatically disabled
May 26, 2021 21:52
Head branch was pushed to by a user without write access
Ok, no problem. Can you bump the Julia compat in the Project.toml too? |
OK I update the version accordingly |
Just tried it out locally: ❯ searchable P\ -\ W\ 93.pdf
ERROR: LoadError: BoundsError: attempt to access 1-codeunit String at index [2:2]
Stacktrace:
[1] command_main(ARGS::Vector{String})
@ SearchablePDFs ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[2] command_main()
@ SearchablePDFs ~/.julia/packages/ComoniconTargetExpr/mjfvh/src/emit.jl:53
[3] top-level scope
@ ~/.julia/bin/searchable.jl:1
[4] include_string(mapexpr::typeof(identity), mod::Module, code::String, filename::String)
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[5] _include(mapexpr::Function, mod::Module, _path::String)
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[6] include(mod::Module, _path::String)
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[7] exec_options(opts::Base.JLOptions)
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[8] _start()
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
in expression starting at /Users/eph/.julia/bin/searchable.jl:1
❯ searchable "P - W93.pdf"
ERROR: LoadError: BoundsError: attempt to access 1-codeunit String at index [2:2]
Stacktrace:
[1] command_main(ARGS::Vector{String})
@ SearchablePDFs ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[2] command_main()
@ SearchablePDFs ~/.julia/packages/ComoniconTargetExpr/mjfvh/src/emit.jl:53
[3] top-level scope
@ ~/.julia/bin/searchable.jl:1
[4] include_string(mapexpr::typeof(identity), mod::Module, code::String, filename::String)
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[5] _include(mapexpr::Function, mod::Module, _path::String)
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[6] include(mod::Module, _path::String)
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[7] exec_options(opts::Base.JLOptions)
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
[8] _start()
@ Base ~/SearchablePDFs.jl/deps/lib/libsearchable.dylib:-1
in expression starting at /Users/eph/.julia/bin/searchable.jl:1
❯ mv "P - W 93.pdf" "P-W93.pdf"
❯ searchable P-W93.pdf
Starting to ocr `P-W93.pdf`; result will be located at `P-W93_OCR.pdf`.
(1/3) Extracting images: 7%|████▍ | ETA: 0:00:41(1/3) Extracting images: 10%|██████▋ | ETA: 0:00:26(1/3) Extracting images: 13%|████████▉ | ETA: 0:00:19(1/3) Extracting images: 17%|███████████ | ETA: 0:00:15(1/3) Extracting images: 20%|█████████████▎ | ETA: 0:00:12(1/3) Extracting images: 23%|███████████████(1/3) Extracting images: 100%|███████████████████████████████████████████████████████████████████| Time: 0:00:07
(2/3) OCRing: 26%|████████████████████▋ | ETA: 0:02:42
seems like spaces aren't handled right, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you want to use a system image or even just build an app for this, I find this package itself is quite slow to start (costs over 1s on my machine), after you enable system image build it only costs 200ms. I enabled it in this PR.
There will be some instability for version 0.11 since it's a brand new rewrite, 0.11 is also a little bit slower since we support parsing more syntax in the terminal.