more tests, more work on generatePhpEnum()

ericsizemore · Apr 25, 2024 · 550a046 · 550a046
1 parent 26f3147
commit 550a046
Show file tree

Hide file tree

Showing 2 changed files with 124 additions and 15 deletions.
diff --git a/src/Mapping/Generator.php b/src/Mapping/Generator.php
@@ -139,12 +139,12 @@ public function generateMapping(): array
     public function generatePhpEnum(string $classname = 'MimeType', string $namespace = 'Esi\Mimey'): string
     {
         $values = [
-            'namespace'       => $namespace,
-            'classname'       => $classname,
-            'interface_usage' => $namespace !== __NAMESPACE__ ? ('use ' . MimeTypeInterface::class . ";\n") : '',
-            'cases'           => '',
-            'type2ext'        => '',
-            'ext2type'        => '',
+            '%namespace%'       => $namespace,
+            '%classname%'       => $classname,
+            '%interface_usage%' => $namespace !== __NAMESPACE__ ? ('use ' . MimeTypeInterface::class . ";\n") : '',
+            '%cases%'           => '',
+            '%type2ext%'        => '',
+            '%ext2type%'        => '',
         ];
 
         $stubContents = (string) file_get_contents(\dirname(__DIR__, 2) . '/stubs/mimeType.php.stub');
@@ -160,19 +160,19 @@ public function generatePhpEnum(string $classname = 'MimeType', string $namespac
         foreach ($mapping['extensions'] as $mime => $extensions) {
             $nameMap[$mime] = $this->convertMimeTypeToCaseName($mime);
 
-            $values['cases'] .= sprintf(Generator::spaceIndent(4, "case %s = '%s';\n"), $nameMap[$mime], $mime);
-            $values['type2ext'] .= sprintf(Generator::spaceIndent(12, "self::%s => '%s',\n"), $nameMap[$mime], $extensions[0]);
+            $values['%cases%'] .= sprintf(Generator::spaceIndent(4, "case %s = '%s';\n"), $nameMap[$mime], $mime);
+            $values['%type2ext%'] .= sprintf(Generator::spaceIndent(12, "self::%s => '%s',\n"), $nameMap[$mime], $extensions[0]);
         }
 
         foreach ($mapping['mimes'] as $extension => $mimes) {
-            $values['ext2type'] .= sprintf(Generator::spaceIndent(12, "'%s' => self::%s,\n"), $extension, $nameMap[$mimes[0]]);
+            $values['%ext2type%'] .= sprintf(Generator::spaceIndent(12, "'%s' => self::%s,\n"), $extension, $nameMap[$mimes[0]]);
         }
 
-        foreach ($values as $name => $value) {
-            $stubContents = str_replace("%$name%", $value, $stubContents);
-        }
-
-        return $stubContents;
+        return str_replace(
+            array_keys($values),
+            array_values($values),
+            $stubContents
+        );
     }
 
     /**
@@ -188,7 +188,7 @@ protected function convertMimeTypeToCaseName(string $mimeType): string
     }
 
     /**
-     * Helper function for self::generateMapping()
+     * Helper function for self::generateMapping().
      *
      * @param list<string> $parts
      */

diff --git a/tests/src/GeneratorTest.php b/tests/src/GeneratorTest.php
@@ -200,6 +200,85 @@ public static function tryFromExtension(string \$extension): ?MimeType
         );
     }
 
+    /**
+     * Test generating the PHP Enum from the given mime.types text.
+     */
+    public function testGeneratePhpEnumDefault(): void
+    {
+        $generator = new Generator(
+            <<<EOF
+                #ignore
+                application/json\tjson
+                image/jpeg\tjpeg jpg
+                EOF
+        );
+
+        $phpEnum = $generator->generatePhpEnum();
+
+        self::assertSame(
+            <<<EOF
+                <?php
+
+                /**
+                 * @generated enum generated using bin/generate.php, please DO NOT EDIT!
+                 *
+                 * @codeCoverageIgnore
+                 */
+                declare(strict_types=1);
+
+                namespace Esi\Mimey;
+
+                use InvalidArgumentException;
+                use Esi\Mimey\Interface\MimeTypeInterface;
+
+                enum MimeType: string implements MimeTypeInterface
+                {
+                    case ApplicationJson = 'application/json';
+                    case ImageJpeg = 'image/jpeg';
+
+                    #[\Override]
+                    public function getExtension(): string
+                    {
+                        return match(\$this) {
+                            self::ApplicationJson => 'json',
+                            self::ImageJpeg => 'jpeg',
+
+                        };
+                    }
+
+                    #[\Override]
+                    public function getValue(): string
+                    {
+                        return \$this->value;
+                    }
+
+                    public static function fromExtension(string \$extension): MimeType
+                    {
+                        \$type = self::tryFromExtension(\$extension);
+
+                        if (\$type === null) {
+                            throw new InvalidArgumentException('Unknown extension: ' . \$extension);
+                        }
+                        return \$type;
+                    }
+
+                    public static function tryFromExtension(string \$extension): ?MimeType
+                    {
+                        return match(\$extension) {
+                            'json' => self::ApplicationJson,
+                            'jpeg' => self::ImageJpeg,
+                            'jpg' => self::ImageJpeg,
+
+                            default => null,
+                        };
+                    }
+                }
+
+                EOF,
+            $phpEnum
+        );
+    }
+
     /**
      * Test generating the PHP Enum when given invalid mime.types text.
      */
@@ -217,6 +296,36 @@ public function testGeneratePhpEnumInvalid(): void
         $generator->generatePhpEnum('TestMimeClass', 'TestMimeNamespace');
     }
 
+    /**
+     * Test generating the PHP Enum when given invalid mime.types text.
+     *
+     * @psalm-suppress InvalidArgument
+     */
+    public function testGeneratePhpEnumInvalidNoParam(): void
+    {
+        $generator = new Generator('');
+
+        $this->expectException(RuntimeException::class);
+        $generator->generatePhpEnum('TestMimeClass', 'TestMimeNamespace');
+    }
+
+    /**
+     * Test generating the PHP Enum when given invalid mime.types text.
+     */
+    public function testGeneratePhpEnumInvalidNoTab(): void
+    {
+        $generator = new Generator(
+            <<<'EOF'
+                #ignore
+                application/jsonjson
+                image/jpegjpegjpg
+                EOF
+        );
+
+        $this->expectException(RuntimeException::class);
+        $generator->generatePhpEnum('TestMimeClass', 'TestMimeNamespace');
+    }
+
     public function testSpaceIndent(): void
     {
         $spaceIndent = new ReflectionMethod(Generator::class, 'spaceIndent');