Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browser support #3

Closed
nonplus opened this issue Oct 25, 2014 · 4 comments
Closed

Add browser support #3

nonplus opened this issue Oct 25, 2014 · 4 comments

Comments

@nonplus
Copy link
Contributor

nonplus commented Oct 25, 2014

I'd like to use safe-access in my browser app. Right now it's set up as a Node module.

In order to support it in a browser, the following should be added:

  • Add wrapper to make it Node, AMD and browser compatible
  • Add a bower configuration s.t. it can be published/accessed via bower
  • Documentation should be update with browser instructions

I'd be happy to make these changes and issue a PR.
nonplus added a commit to nonplus/safe-access that referenced this issue Oct 26, 2014
@nonplus
Reorganized files to make them browser friendly for erictrinh#3.
88e2c94
@erictrinh
Copy link
Owner

Thanks for the PR again! I just registered the package on bower and added installation instructions to the readme.

@nonplus
Copy link
Contributor Author

nonplus commented Oct 26, 2014

Cool. You should also bump the version for bower and for npm to 0.2.0 or 0.1.1 and then release it through GitHub.

@erictrinh
Copy link
Owner

Will do!

@erictrinh
Copy link
Owner

Done! Thanks for your help with this @nonplus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nonplus @erictrinh