Clarify README, destroy by default and fix temp dir bug #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The safest thing is to destroy all evidence, so destroy by default.
The os.tmpDir() and 'id_rsa' where concatenated without a slash. Use the path.join method to join the directories which will add a slash if needed.
|
Looks good, thanks for the contribution! |
ericvicenti
added a commit
that referenced
this pull request
Apr 24, 2013
Clarify README, destroy by default and fix temp dir bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed three things. The readme, default behaviour and fixed a bug in temp dir location generation.
README.md
I've added all defaults to the parameters listed in the readme.
Default behaviour
Detroy is now enabled by default. This is the safest way to use ssh-keygen because it leaves no evidence by default. It also generates the lowest waste, which keeps the temp dir clean by default.
Temp dir location generation
When location is not provided, ssh-keygen generates a temp path. This generation didn't split the temp directory and key directory name with a slash. I changed the code to use
path.join.