Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid spotlight on models with _phong 1 #172

Open
danpla opened this issue Sep 9, 2017 · 4 comments
Open

Invalid spotlight on models with _phong 1 #172

danpla opened this issue Sep 9, 2017 · 4 comments

Comments

@danpla
Copy link

danpla commented Sep 9, 2017

tyrutils-ericw v0.15.10 on Linux x64

Here is a screenshot:
spasm0000

It's a func_detail entity containing a cuboid with a "rounded" side and _phong 1.

An example map from the screenshot:

// Game: Quake
// Format: Standard
// entity 0
{
"classname" "worldspawn"
"wad" "Q.wad"
"light" "20"
// brush 0
{
( 192 192 -32 ) ( 192 192 -64 ) ( 192 -192 -64 ) wmet3_3 -0 -0 -0 1 1
( -192 192 -32 ) ( -192 -192 -32 ) ( -192 -192 -64 ) wmet3_3 -0 -0 -0 1 1
( -192 192 -64 ) ( 192 192 -64 ) ( 192 192 -32 ) wmet3_3 -0 -0 -0 1 1
( -192 -192 -64 ) ( -192 -192 -32 ) ( 192 -192 -32 ) wmet3_3 -0 -0 -0 1 1
( 192 -192 -32 ) ( -192 -192 -32 ) ( -192 192 -32 ) wmet3_3 -0 -0 -0 1 1
( 192 -192 -64 ) ( 192 192 -64 ) ( -192 192 -64 ) wmet3_3 -0 -0 -0 1 1
}
// brush 1
{
( 192 192 384 ) ( 192 192 352 ) ( 192 -192 352 ) wmet3_3 -0 -0 -0 1 1
( -192 192 384 ) ( -192 -192 384 ) ( -192 -192 352 ) wmet3_3 -0 -0 -0 1 1
( -192 192 352 ) ( 192 192 352 ) ( 192 192 384 ) wmet3_3 -0 -0 -0 1 1
( -192 -192 352 ) ( -192 -192 384 ) ( 192 -192 384 ) wmet3_3 -0 -0 -0 1 1
( 192 -192 384 ) ( -192 -192 384 ) ( -192 192 384 ) wmet3_3 -0 -0 -0 1 1
( 192 -192 352 ) ( 192 192 352 ) ( -192 192 352 ) wmet3_3 -0 -0 -0 1 1
}
// brush 2
{
( 224 -192 352 ) ( 224 192 352 ) ( 224 192 -32 ) wmet3_3 -0 0 90 1 -1
( 192 -192 352 ) ( 192 -192 -32 ) ( 192 192 -32 ) wmet3_3 -0 0 90 1 -1
( 224 192 -32 ) ( 224 192 352 ) ( 192 192 352 ) wmet3_3 -0 -0 90 1 1
( 224 -192 -32 ) ( 192 -192 -32 ) ( 192 -192 352 ) wmet3_3 -0 -0 90 1 1
( 192 192 352 ) ( 224 192 352 ) ( 224 -192 352 ) wmet3_3 -0 -0 90 1 1
( 192 192 -32 ) ( 192 -192 -32 ) ( 224 -192 -32 ) wmet3_3 -0 -0 90 1 1
}
// brush 3
{
( -192 -192 352 ) ( -192 192 352 ) ( -192 192 -32 ) wmet3_3 -0 -0 90 1 -1
( -224 -192 352 ) ( -224 -192 -32 ) ( -224 192 -32 ) wmet3_3 -0 -0 90 1 -1
( -192 192 -32 ) ( -192 192 352 ) ( -224 192 352 ) wmet3_3 0.999985 0 90 1 1
( -192 -192 -32 ) ( -224 -192 -32 ) ( -224 -192 352 ) wmet3_3 0.999985 0 90 1 1
( -224 192 352 ) ( -192 192 352 ) ( -192 -192 352 ) wmet3_3 -0 -0 90 1 1
( -224 192 -32 ) ( -224 -192 -32 ) ( -192 -192 -32 ) wmet3_3 -0 -0 90 1 1
}
// brush 4
{
( 192 192 -32 ) ( 192 192 352 ) ( 192 224 352 ) wmet3_3 -0 -0 89.9999 1 -1
( -192 192 -32 ) ( -192 224 -32 ) ( -192 224 352 ) wmet3_3 -0 -0 89.9999 1 -1
( -192 224 352 ) ( -192 224 -32 ) ( 192 224 -32 ) wmet3_3 -0 -0 90 1 -1
( -192 192 352 ) ( 192 192 352 ) ( 192 192 -32 ) wmet3_3 -0 -0 90 1 -1
( 192 224 352 ) ( 192 192 352 ) ( -192 192 352 ) wmet3_3 -0 -0 -0 1 1
( 192 224 -32 ) ( -192 224 -32 ) ( -192 192 -32 ) wmet3_3 -0 -0 -0 1 1
}
// brush 5
{
( 192 -224 -32 ) ( 192 -224 352 ) ( 192 -192 352 ) wmet3_3 -0 -0 89.9999 1 -1
( -192 -224 -32 ) ( -192 -192 -32 ) ( -192 -192 352 ) wmet3_3 -0 -0 89.9999 1 -1
( -192 -192 352 ) ( -192 -192 -32 ) ( 192 -192 -32 ) wmet3_3 -0 -0.999992 90 1 -1
( -192 -224 352 ) ( 192 -224 352 ) ( 192 -224 -32 ) wmet3_3 -0 -0.999992 90 1 -1
( 192 -192 352 ) ( 192 -224 352 ) ( -192 -224 352 ) wmet3_3 -0 -0 -0 1 1
( 192 -192 -32 ) ( -192 -192 -32 ) ( -192 -224 -32 ) wmet3_3 -0 -0 -0 1 1
}
}
// entity 1
{
"classname" "info_null"
"origin" "56 -8 88"
"angle" "-0"
"targetname" "light_point"
}
// entity 2
{
"classname" "light"
"origin" "56 -8 104"
"angle" "90"
"target" "light_point"
"delay" "2"
"light" "500"
}
// entity 3
{
"classname" "info_player_start"
"origin" "-112 -16 -8"
"angle" "-0"
}
// entity 4
{
"classname" "light"
"origin" "104 -8 104"
"angle" "-0"
"light" "500"
}
// entity 5
{
"classname" "func_detail"
"_phong" "1"
// brush 0
{
( 92 124 112 ) ( 80 128 112 ) ( 80 128 -32 ) wmet3_3 -0 -48 -0 1 1
( 96 112 -32 ) ( 96 112 112 ) ( 92 124 112 ) wmet3_3 -16 -48 -0 1 1
( 96 -128 112 ) ( 96 112 112 ) ( 96 112 -32 ) wmet3_3 -16 -48 -0 1 1
( 68 124 -32 ) ( 68 124 112 ) ( 64 112 112 ) wmet3_3 -16 -48 -0 1 1
( 80 128 -32 ) ( 80 128 112 ) ( 68 124 112 ) wmet3_3 -0 -48 -0 1 1
( 64 -128 -32 ) ( 64 112 -32 ) ( 64 112 112 ) wmet3_3 -16 -48 -0 1 1
( 96 -128 112 ) ( 96 -128 -32 ) ( 64 -128 -32 ) wmet3_3 -0 -48 -0 1 1
( 92 124 112 ) ( 96 112 112 ) ( 96 -128 112 ) wmet3_3 -0 16 -0 1 1
( 96 -128 -32 ) ( 96 112 -32 ) ( 92 124 -32 ) wmet3_3 -0 16 -0 1 1
}
}

@ericwa
Copy link
Owner

ericwa commented Sep 16, 2017

Thanks for the report.
It seems this bug was introduced in 53743dd , although I am confused by that.

f54abd9:
spasm0002
spasm0003
spasm0006

53743dd:
spasm0005
spasm0004
spasm0007

@ericwa ericwa closed this as completed in 26c5f65 Sep 16, 2017
@ericwa
Copy link
Owner

ericwa commented Sep 16, 2017

Ok - should be fixed by 26c5f65

@danpla
Copy link
Author

danpla commented Sep 17, 2017

Thanks!

@ericwa
Copy link
Owner

ericwa commented Oct 1, 2017

Unfortunately had to revert this patch because it caused another issue: #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants