-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looks like some overlapping PRs remove other recent additions #60
Comments
Oh, I love this idea! Is this something you'd like to take on, or something I should mark as help wanted? |
Sure I'll do it, will get to it in the next couple days! |
Oh my gosh, wow. Thank you! |
…ther than all added to a single members.json file.
PR ready for review, it worked but with one caveat I noted in the PR description. |
Co-authored-by: Steven Woodson <@stevenwoodson>
Closing via this great PR: #67. Thank you again for doing this! |
@stevenwoodson Looks like there's one last little bit to be hooked up. I get the following error when trying to navigate to the next webring member:
Stack trace:
Similar errors for the previous and random links. It looks like we have to update this bit in |
Oh no! Sorry about that I wasn't aware other parts of the codebase relied on that structure. Okay let me check it out and report back. |
…at relied on the previous format of all members in one static file. Changed to use `glob` to import all files into the members array instead.
New PR started, it's working but my familiarity with Netlify is minimal so I'd appreciate some additional validation! |
Slightly different error this time, but this signals process to me!
Stack trace:
|
Thanks for being willing to give these a try on prod! Just opened PR #79. I did some more digging and decided to instead use the FileSystem module native to Node (fs) so we can bypass the glob error altogether. We didn't 100% need to only find JSON files because we can be reasonably sure that directory is only going to include all files we want to compile into |
Here's the latest error I'm seeing:
Stack trace:
|
Okay, thanks for trying! I'm going to dive in and start a trial Netlify account to debug quicker on my ow first before opening another PR |
Just opened PR #81! Of course, it was a one line fix. Once I got a Netlify account set up and able to test myself it was easier to figure out. |
It works! 🎉 🥳 |
YAY |
Your issue
👋 Got the notification that my PR was merged so I took a peek and realized that a few of us had changes overwritten by future merges. Looks like
I did see that you fairly quickly fixed that with Fix
members.json
#59 but I can imagine that manual work can get tedious.Potential Solution
I could work up a proof of concept but am fairly sure you can create a directory under
data
(likemembers
) and then folks can create individual JSON files therein, rather than all collected in one file.Code of conduct
The text was updated successfully, but these errors were encountered: