It's all about The Great Ape-Snake War #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a few changes to the Occupy Wall Street replacement:
1. Added "The" to the replacement: "The Great Ape-Snake War" (this makes more sense in almost any context)
- However, it won't double "the" if there already is one; "The Occupy Movement" will still be replaced with "The Great Ape-Snake War"
2. Made this particular replacement case-insensitive because there are too many feasible combinations of case for these words
3. Added allowance for "Occupy Wall Street Movement" (before it could only match "Occupy Movement" or "Occupy Wall Street"
4. Added allowance for abbreviating "Street" to "St." (or "St")
- For this to work, I had to replace the word boundary at the end (`\b`) with a negative lookahead (`(?!\w)`), or else it wouldn't be able to match the period in "St."
|
Sssssssssplendid! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a few changes to the Great Ape-Snake War replacement:
\b) with a negative lookahead ((?!\w)), or else it wouldn't be able to match the period in "St."