Fix Circle constructor when passing center

ericyd · Jan 19, 2024 · 6b0b859 · 6b0b859
1 parent 018011e
commit 6b0b859
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/components/circle.js b/lib/components/circle.js
@@ -38,8 +38,8 @@ export class Circle extends Tag {
               'Must pass either `x` and `y` or `center` arguments to Circle constructor',
             )
     super('circle', {
-      cx: x,
-      cy: y,
+      cx: i,
+      cy: j,
       r: radius,
       ...attributes,
     })
@@ -95,7 +95,6 @@ export class Circle extends Tag {
    * @returns {boolean}
    */
   contains(point) {
-    console.log(point.distanceTo(this.#center))
     return point.distanceTo(this.#center) <= this.#radius
   }
 

diff --git a/lib/components/circle.test.js b/lib/components/circle.test.js
@@ -10,13 +10,17 @@ describe('Circle', () => {
       assert.strictEqual(c.x, 10)
       assert.strictEqual(c.y, 12)
       assert.strictEqual(c.radius, 5)
+      assert.strictEqual(c.attributes.cx, 10)
+      assert.strictEqual(c.attributes.cy, 12)
     })
 
     it('can be constructed with center, radius', () => {
       const c = new Circle({ center: vec2(10, 12), radius: 5 })
       assert.strictEqual(c.x, 10)
       assert.strictEqual(c.y, 12)
       assert.strictEqual(c.radius, 5)
+      assert.strictEqual(c.attributes.cx, 10)
+      assert.strictEqual(c.attributes.cy, 12)
     })
 
     it('will throw error without either (x,y) or center', () => {