acks: automatic for .send and manual for .emit

ericz · Jun 29, 2011 · 8ce05bc · 8ce05bc
1 parent 27be7ac
commit 8ce05bc
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/namespace.js b/lib/namespace.js
@@ -1,4 +1,3 @@
-
 /**
  * socket.io
  * Copyright(c) 2011 LearnBoost <dev@learnboost.com>
@@ -70,7 +69,7 @@
 
     if ('function' == typeof fn) {
       packet.id = ++this.ackPackets;
-      packet.ack = fn.length ? 'data' : true;
+      packet.ack = true;
       this.acks[packet.id] = fn;
     }
 
@@ -93,7 +92,7 @@
 
     if ('function' == typeof lastArg) {
       packet.id = ++this.ackPackets;
-      packet.ack = lastArg.length ? 'data' : true;
+      packet.ack = 'data';
       this.acks[packet.id] = lastArg;
       args = args.slice(0, args.length - 1);
     }