New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New spectrum color scheme #744
Conversation
Thanks 🙏 |
Can't we go a bit further and implement a switch to allow the 2 color modes (and eventually more ?) |
Yes, it's easy to do |
Hi @strijar , |
Hi again , let's merge it , and feel free to check that new Waterfall spectrum colour scheme in the new nightly firmware. |
Olá, é possível acrescentar a largura de banda de 100khz, ficaria mais preciso a leitura. |
Hello @samukas81 , Cheers |
Olá obrigado por responder, não é um problema seria apenas uma implementação interessante! |
I think it's always better to give users a choice rather than make choices for them, especially for subjective things like color palettes. I would like to see this as an optional choice in settings rather than something forced with no option. |
Hi thanks @AlphaGeek1 for your feedback. I agree with you that is a subjective feature issue . But the developer launched it , one month ago , and as it is not related to any stability issue, we need to take some quick decision about it. In my personal opinion, i like it more than current one, and I prefer it . I feel that warm white and yellow colours give me a more clear image about too much RX signal , but it is just my opinion . |
I agree, this should be an option and not forced |
@jLynx , you can revert it , no problem at all |
Happy to keep it in as is for now. But if we could get another PR to make it as an option, that would be great |
Actually having second thoughts now on weather it's even worth adding a option for it. Maybe it's fine as is. Anyone else have any strong opinions? |
Seria legal poder escolher entre as duas cores, acredito não ser difícil fazer. |
I also think it is ok with 1 scheme only. Unless users disagree |
Se não for muito complexo seria interessante ter duas opções, obrigado. |
Why not make it so that the theme is an editable file on the SD card? That way, anyone with the time and desire could change it. Include the default sunset scheme and the original scheme (as another file). This way, it's settable (with the effort of changing/editing a file), the users have a choice not just between the two schemes because they could make their own if they choose, and there isn't an additional hit on limited memory. |
I have implemented a new, more pleasing color scheme for the waterfall (like a sunset)