Merge branch 'master' into ci/machine24

erigontech · Jul 5, 2024 · 550f188 · 550f188
2 parents b973960 + f260cfa
commit 550f188
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/docs/JSON-RPC-API.md b/docs/JSON-RPC-API.md
@@ -31,13 +31,13 @@ The following table shows the current [JSON RPC API](https://eth.wiki/json-rpc/A
 | eth_getUncleCountByBlockHash               |     Yes      |                                           |     Yes     |             |
 | eth_getUncleCountByBlockNumber             |     Yes      |                                           |     Yes     |             |
 |                                            |              |                                           |             |             |
-| eth_getTransactionByHash                   |     Yes      |                     partially implemented |     Yes     |     Yes     |
-| eth_getRawTransactionByHash                |     Yes      |                     partially implemented |     Yes     |             |
+| eth_getTransactionByHash                   |     Yes      |                                           |     Yes     |     Yes     |
+| eth_getRawTransactionByHash                |     Yes      |                                           |     Yes     |             |
 | eth_getTransactionByBlockHashAndIndex      |     Yes      |                                           |     Yes     |             |
-| eth_getRawTransactionByBlockHashAndIndex   |     Yes      |                     partially implemented |     Yes     |             |
+| eth_getRawTransactionByBlockHashAndIndex   |     Yes      |                                           |     Yes     |             |
 | eth_getTransactionByBlockNumberAndIndex    |     Yes      |                                           |     Yes     |             |
-| eth_getRawTransactionByBlockNumberAndIndex |     Yes      |                     partially implemented |     Yes     |             |
-| eth_getTransactionReceipt                  |     Yes      |                     partially implemented |     Yes     |     Yes     |
+| eth_getRawTransactionByBlockNumberAndIndex |     Yes      |                                           |     Yes     |             |
+| eth_getTransactionReceipt                  |     Yes      |    partial: retrieve receipts by exec txn |     Yes     |     Yes     |
 | eth_getBlockReceipts                       |     Yes      |           same as parity_getBlockReceipts |     Yes     |             |
 | eth_getTransactionReceiptsByBlock          |     Yes      |           same as parity_getBlockReceipts |             |             |
 |                                            |              |                                           |             |             |
@@ -47,9 +47,9 @@ The following table shows the current [JSON RPC API](https://eth.wiki/json-rpc/A
 | eth_getTransactionCount                    |     Yes      |                                           |     Yes     |             |
 | eth_getStorageAt                           |     Yes      |                                           |     Yes     |             |
 | eth_call                                   |     Yes      |                                           |     Yes     |     Yes     |
-| eth_callMany                               |     Yes      |                     partially implemented |     Yes     |             |
+| eth_callMany                               |     Yes      |   partial: timeout param handling missing |     Yes     |             |
 | eth_callBundle                             |     Yes      |                                           |     Yes     |             |
-| eth_createAccessList                       |     Yes      |                                           |     Yes     |             |
+| eth_createAccessList                       |     Yes      |                                           |     Yes     |     Yes     |
 |                                            |              |                                           |             |             |
 | eth_newFilter                              |     Yes      |                                           |             |             |
 | eth_newBlockFilter                         |      -       |                       not yet implemented |             |             |

diff --git a/silkworm/rpc/core/evm_debug_test.cpp b/silkworm/rpc/core/evm_debug_test.cpp
@@ -43,11 +43,11 @@ using testing::_;
 using testing::Invoke;
 using testing::InvokeWithoutArgs;
 
-static Bytes kZeroKey{*silkworm::from_hex("0000000000000000")};
-static Bytes kZeroHeader{*silkworm::from_hex("bf7e331f7f7c1dd2e05159666b3bf8bc7a8a3a9eb1d518969eab529dd9b88c1a")};
+static const Bytes kZeroKey{*silkworm::from_hex("0000000000000000")};
+static const Bytes kZeroHeader{*silkworm::from_hex("bf7e331f7f7c1dd2e05159666b3bf8bc7a8a3a9eb1d518969eab529dd9b88c1a")};
 
-static Bytes kConfigKey{kZeroHeader};
-static Bytes kConfigValue{string_view_to_byte_view(kSepoliaConfig.to_json().dump())};
+static const Bytes kConfigKey{kZeroHeader};
+static const Bytes kConfigValue{string_view_to_byte_view(kSepoliaConfig.to_json().dump())};  // NOLINT(cppcoreguidelines-interfaces-global-init)
 
 struct DebugExecutorTest : public test_util::ServiceContextTestBase {
     test::MockBlockCache cache;

diff --git a/silkworm/rpc/core/evm_trace_test.cpp b/silkworm/rpc/core/evm_trace_test.cpp
@@ -47,11 +47,11 @@ using testing::_;
 using testing::Invoke;
 using testing::InvokeWithoutArgs;
 
-static Bytes kZeroKey{*silkworm::from_hex("0000000000000000")};
-static Bytes kZeroHeader{*silkworm::from_hex("bf7e331f7f7c1dd2e05159666b3bf8bc7a8a3a9eb1d518969eab529dd9b88c1a")};
+static const Bytes kZeroKey{*silkworm::from_hex("0000000000000000")};
+static const Bytes kZeroHeader{*silkworm::from_hex("bf7e331f7f7c1dd2e05159666b3bf8bc7a8a3a9eb1d518969eab529dd9b88c1a")};
 
-static Bytes kConfigKey{kZeroHeader};
-static Bytes kConfigValue{string_view_to_byte_view(kSepoliaConfig.to_json().dump())};
+static const Bytes kConfigKey{kZeroHeader};
+static const Bytes kConfigValue{string_view_to_byte_view(kSepoliaConfig.to_json().dump())};  // NOLINT(cppcoreguidelines-interfaces-global-init)
 
 struct TraceCallExecutorTest : public test_util::ServiceContextTestBase {
     db::test_util::MockTransaction transaction;