Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

conan: fix Windows build and upgrade to 1.60.2 for macOS #1628

Merged
merged 14 commits into from
Nov 6, 2023

Conversation

canepat
Copy link
Collaborator

@canepat canepat commented Nov 6, 2023

This PR was initially conceived to fix the build on Windows after #1593, but then macOS job started to fail intermittently 馃槶 so, in order to restore full CI green status, it now contains the following changes:

  • fix Windows build broken after sdk: sentry API聽#1593 by not enabling option asio_no_deprecated
  • update Conan to version 1.60.2 on macOS CI job to avoid this error occurred here
  • downgrade Python to version 3.11 because version 3.12 (now present in macos-13 GA image) triggers another error, which will be fixed in not-yet-available Conan 1.62.0

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Nov 6, 2023
Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we update the Conan version in the README as well?

@canepat
Copy link
Collaborator Author

canepat commented Nov 6, 2023

Shall we update the Conan version in the README as well?

Sure, thanks!

@canepat
Copy link
Collaborator Author

canepat commented Nov 6, 2023

I have updated the other jobs as well 馃

@canepat canepat merged commit c7173b2 into master Nov 6, 2023
12 checks passed
@canepat canepat deleted the ci/avoid_asio_no_deprecated_on_win branch November 6, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants