Add sunnyportal2file #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to let you know that I haven't forgot about this PR. I just haven't had time to look at it yet. |
|
All good, cheers Erik :)
-------- Original message --------From: Erik Johansson <notifications@github.com> Date: 18/5/20 1:58 am (GMT+10:00) To: erijo/sunnyportal-py <sunnyportal-py@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: Re: [erijo/sunnyportal-py] Add sunnyportal2file (#9)
Just to let you know that I haven't forgot about this PR. I just haven't had time to look at it yet.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "#9 (comment)",
"url": "#9 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
erijo
added a commit
that referenced
this pull request
May 23, 2020
erijo
added a commit
that referenced
this pull request
May 23, 2020
erijo
reviewed
May 23, 2020
sunnyportal/responses.py
Outdated
| Power = namedtuple('Power', ['timestamp', 'power']) | ||
| Power = namedtuple('Power', ['timestamp', 'min_power','mean_power','max_power']) |
There was a problem hiding this comment.
I've merged these changes in a slightly different form (see 45bcd9d). The power member is still there and the other two are called min and max.
Please rebase your changes ontop of this.
sunnyportal/responses.py
Outdated
| @@ -253,11 +253,13 @@ def parse(self, data): | |||
| self.power_measurements = [] | |||
| tag_name = "fiveteen" if self.quarter else "hour" | |||
| for entry in tag.iterfind('./channel/day/%s' % tag_name): | |||
| mean = self.kw_to_w(entry.get('mean')) | |||
| if mean is not None: | |||
There was a problem hiding this comment.
Instead of always including all power measurements I added a parameter in 2986ad0 to only include it when requested.
…hanged so that also timestamps with no production is included in power_measurements from DayOverviewResponse.parse.
erijo
added a commit
that referenced
this pull request
May 28, 2020
The script can be used to save data from Sunny Portal to a number of different formats.
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file sunnyportal2file can be used to download data from Sunny Portal to file. It currently allows 7 output format (csv, json, pickle, hdf, parquet, feather and excel). It also contains a flag --append which can be used to only download new data and append it to existing file.