Fix calls to logger

squabble/__init__.py

@@ -1,7 +1,6 @@
 import logging
 
 
-logging.basicConfig()
 logger = logging.getLogger(__name__)
 
 

squabble/__main__.py

@@ -1,3 +1,4 @@
+import logging
 import sys
 
 import colorama
@@ -6,6 +7,7 @@
 
 
 def main():
+    logging.basicConfig()
     colorama.init()
     status = cli.main()
 

squabble/cli.py

@@ -24,6 +24,7 @@
 
 import glob
 import json
+import logging
 import os.path
 import sys
 
@@ -33,7 +34,7 @@
 
 import squabble
 import squabble.message
-from squabble import config, lint, logger, reporter, rule
+from squabble import config, lint, reporter, rule
 
 
 def main():
@@ -51,7 +52,7 @@ def dispatch_args(args):
     Note that some exceptional conditions will terminate the program directly.
     """
     if args['--verbose']:
-        logger.setLevel('DEBUG')
+        squabble.logger.setLevel('DEBUG')
 
     if args['--list-presets']:
         return list_presets()

squabble/config.py

@@ -1,11 +1,16 @@
 import collections
 import copy
 import json
+import logging
 import os.path
 import re
 import subprocess
 
-from squabble import SquabbleException, logger
+from squabble import SquabbleException
+
+
+logger = logging.getLogger(__name__)
+
 
 Config = collections.namedtuple('Config', [
     'reporter',
@@ -74,8 +79,6 @@ def discover_config_location():
     - in the root of the repository (if working in a git repo).
     - in the user's home directory.
     """
-    logger.debug('No config file given, trying to discover')
-
     possible_dirs = [
         '.',
         _get_vcs_root(),
@@ -86,12 +89,14 @@ def discover_config_location():
         if d is None:
             continue
 
-        logger.debug('Checking %s for a config file', d)
+        logger.debug('checking %s for a config file', d)
 
         file_name = os.path.join(d, '.squabblerc')
         if os.path.exists(file_name):
+            logger.debug('using "%s" for configuration', file_name)
             return file_name
 
+    logger.debug('no config file found')
     return None
 
 

squabble/message.py

@@ -1,4 +1,9 @@
-from squabble import SquabbleException, logger
+import logging
+
+from squabble import SquabbleException
+
+
+logger = logging.getLogger(__name__)
 
 
 class DuplicateMessageCodeException(SquabbleException):

squabble/rule.py

@@ -2,9 +2,13 @@
 import glob
 import importlib
 import importlib.util as import_util
+import logging
 import os.path
 
-from squabble import UnknownRuleException, logger
+from squabble import UnknownRuleException
+
+
+logger = logging.getLogger(__name__)
 
 
 def _load_plugin(path):

squabble/rules/require_concurrent_index.py

@@ -1,11 +1,15 @@
+import logging
+
 import pglast
 
 import squabble.rule
-from squabble import logger
 from squabble.message import Message
 from squabble.rules import BaseRule
 
 
+logger = logging.getLogger(__name__)
+
+
 class RequireConcurrentIndex(BaseRule):
     """
     Require all new indexes to be created with ``CONCURRENTLY`` so they won't