Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program error when using --local flag #428

Closed
wangchengdng opened this issue Jun 16, 2023 · 0 comments · Fixed by #442
Closed

Program error when using --local flag #428

wangchengdng opened this issue Jun 16, 2023 · 0 comments · Fixed by #442

Comments

@wangchengdng
Copy link

Hello,

I encountered a problem while using the --local feature. I ran the following command to test faiss-ivf:

python run.py --dataset random-s-100-euclidean --runs 1 --local --algorithm=faiss-ivf

However, the program threw the following error:

Traceback (most recent call last):
  File "run.py", line 7, in <module>
    main()
  File "/root/ann-benchmark/ann_benchmarks/main.py", line 185, in main
    definitions = [d for d in definitions if _test(d)]
  File "/root/ann-benchmark/ann_benchmarks/main.py", line 185, in <listcomp>
    definitions = [d for d in definitions if _test(d)]
  File "/root/ann-benchmark/ann_benchmarks/main.py", line 168, in _test
    raise Exception(
Exception: ann_benchmarks.algorithms.faiss.FaissIVF(['euclidean', 2048]): error: the module 'ann_benchmarks.algorithms.faiss' does not expose the named constructor

I found that the code is checking the validity of the constructor at this line:
https://github.com/erikbern/ann-benchmarks/blob/main/ann_benchmarks/definitions.py#L36
It imports the module using definition.module, but I noticed that the actual directory of the constructor is f"{definition.module}.module. Is this a bug?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant