Features/106 oracle - Added Oracle support #134
Conversation
* Oracle is a bit different to MS SQL, PostgreSQL and MariaDB, so there were a couple of changes * Interpret 'Create database' as 'Create user' on Oracle DB, as a user with a schema is maybe the closest thing to a 'database' in other DBMSs * Some restructuring/new extension points to make Oracle support * Restructured and cleaned up code a bit
erikbra
force-pushed
the
features/106-oracle
branch
from
df8c01a
to
5a41eac
Compare
erikbra
changed the title
|
Would someone please just take a quick look at this one before I merge? Do you see any issues with some of the changes made to make Oracle support possible? Maybe @bptillman or @wokket ? |
|
I'm AFK for a while I'm afraid on holidays. If I can get a chance I'll
try and have a look, but I have 0 Oracle experience.
…On Sun, 14 Nov. 2021, 08:18 Erik A. Brandstadmoen, ***@***.***> wrote:
Would someone please just take a quick look at this one before I merge? Do
you see any issues with some of the changes made to make Oracle support
possible? Maybe @bptillman <https://github.com/bptillman> or @wokket
<https://github.com/wokket> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#134 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5ANTLDNMJHE7MNRZMRAWLUL3P2RANCNFSM5H7CFPVQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
No worries, @wokket - enjoy your holidays! I'll just leave it open for a little while, and if no one comments, I'll just merge it. Don't bother getting into this on holiday. Enjoy life! 😆 |
|
Like @wokket , I do not have Oracle experience. But if you'd like I can take a look at this PR and test it out a bit to see if I see anything obvious that needs fixing before you merge it |
|
Yes, please. I haven't worked with Oracle in 15 years, so I was more thinking of just taking a quick look over the changes. If you don't have any specific Oracle knowledge, don't sweat it a lot. |
|
@erikbra I finally got a chance to look over this after your merge, and nothing stands out to me as needing to change 👍 |
|
Thanks. Sorry, I pulled the trigger 🤓 |
Implemented Oracle support.