Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MSI for Windows #74

Merged
merged 16 commits into from
Oct 10, 2021
Merged

Create MSI for Windows #74

merged 16 commits into from
Oct 10, 2021

Conversation

erikbra
Copy link
Owner

@erikbra erikbra commented Oct 10, 2021

Create an MSI installer

  • Installs to current user folder (not Program Files)
  • No dependencies
  • Only x64 for now (could expand to build x86 too, if desired)

@wokket
Copy link
Collaborator

wokket commented Oct 10, 2021

Built an installer nicely on my Windows box 👍

@erikbra
Copy link
Owner Author

erikbra commented Oct 10, 2021

Have you tried executing the installer on you box, @wokket ? It worked on my box. I install to a user folder (LocalAppData), to avoid needing admin privileges

@wokket
Copy link
Collaborator

wokket commented Oct 10, 2021

I did run the installer. It created a folder/.exe fine (although because I passed a path to a non-self contained exe it won't actually run....)

image

@erikbra
Copy link
Owner Author

erikbra commented Oct 10, 2021

Thanks for testing it, @wokket ! I'll merge this, and move on to trying to get it into the winget package manager:

https://docs.microsoft.com/en-us/windows/package-manager/package/manifest

@erikbra erikbra merged commit 8e20a4b into main Oct 10, 2021
@erikbra erikbra deleted the features/69-msi branch October 10, 2021 11:26
@erikbra
Copy link
Owner Author

erikbra commented Oct 10, 2021

Solves #69

@erikbra erikbra mentioned this pull request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants