Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue building for iOS - atomicfu #65

Closed
liujoshua opened this issue May 19, 2020 · 6 comments · Fixed by #67
Closed

Issue building for iOS - atomicfu #65

liujoshua opened this issue May 19, 2020 · 6 comments · Fixed by #67
Assignees
Labels
bug Something isn't working

Comments

@liujoshua
Copy link

liujoshua commented May 19, 2020

I have been trying to fix this build error on iOS item and finally narrowed it down to island-time. I added Kotlin atomicfu and made various other attempts to fix it

Extracting dependency: /Users/runner/.konan/cache/clang-llvm-apple-8.0.0-darwin-macos.tar.gz into /Users/runner/.konan/dependencies
e: Could not find "atomicfu-cinterop-interop" in [/Users/runner/runners/2.262.1/work/ReimaginedLampMobileApps/ReimaginedLampMobileApps, /Users/runner/.konan/klib, /Users/runner/.konan/kotlin-native-macos-1.3.71/klib/common, /Users/runner/.konan/kotlin-native-macos-1.3.71/klib/platform/ios_x64].

Is there a sample project I could look at?

Here is a branch and build for repro

Thank you for making this library, hope to use it

@erikc5000
Copy link
Owner

Unfortunately, I don't have a sample project at the moment. Adding one to the repo would probably be a good idea though.

As far as the issue itself, nothing stands out at first glance. I'll take a closer look later today.

One thing I might suggest is moving to Gradle 6.x, if possible, since there have been various fixes related to Gradle Metadata, which was also moved out of preview.

@erikc5000 erikc5000 added the bug Something isn't working label May 19, 2020
@erikc5000 erikc5000 self-assigned this May 19, 2020
@liujoshua
Copy link
Author

Thanks for the reply! I updated the branch mentioned above to use gradle 6.0.1 and see the same issue. Here's the new run: https://github.com/liujoshua/KMPDependenciesTest/runs/690112034?check_suite_focus=true

@liujoshua
Copy link
Author

I saw the new issue you created to add sample apps. The repro branch I linked to was a freshly generated Kotlin Native project in IntelliJ 2020.1. If I can fix the build, I'd be happy to start a new project and turn it into a walk through of how to bootstrap a iOS + Android with Island Time

@erikc5000
Copy link
Owner

That would be awesome!

It looks like Island Time's dependency on atomicfu isn't getting published to Maven correctly. I'll try to get that fixed soon and fire off a new release.

In the meantime, you can work around it by adding the dependency manually to commonTest:

       sourceSets["commonTest"].dependencies {
        implementation(kotlin("test-common"))
        implementation(kotlin("test-annotations-common"))

        // Workaround for https://github.com/erikc5000/island-time/issues/65
        implementation("org.jetbrains.kotlinx:atomicfu-common:0.14.2")
    }

@liujoshua
Copy link
Author

Adding atomicfu to commonTest didn't resolve the issue. Thanks for taking a look. I'll check back for a new release in a few days

@liujoshua
Copy link
Author

Can confirm that upgrading from 0.2.1 to 0.2.2 fixed the issue for me! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants