Re-work clock implementation #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikc5000
added a commit
that referenced
this pull request
Aug 16, 2020
* Re-work the clock implementation on JVM * Re-work new clock implementation to handle Darwin * Minor clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new clock implementation takes advantage of java.time APIs that couldn't be supported in the core before desugaring became available on Android. Precision is increased up to the nanosecond -- assuming the platform supports it. Newer JDK versions and Darwin can take advantage of this.
It's now possible to convert between java.time's
Clocktype and Island Time'sClocktype.Close #6.