-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker support #72
Conversation
I have never really done anything with Docker so if you could set up these things that would be great. |
Tried it, but I would need access to Github repo to set up an automated build. Perhaps having read only access would do. What needs to be done:
Let me know if you need any help. |
I have added you as collaborator. Does this give you enough access? |
Tried it hard, but no way to create the automated build. :( |
I don't think that's access I can give without moving the repo to some organization account I think. Would it be possible to email me which keys to add? |
Hi @erikdubbelboer. Back then I looked how to do that and found no way. Checked again just now and looks the same. I think that no keys you send me will allow me setup the build. Docker Hub adds the keys to Github as part of its Automated Build creation wizard, and I haven't found anywhere to set them manually. |
I have never done anything with Docker before so it's not my image :) |
Ops. Are you interested in that specific username? We can ping the owner and ask him/her to host there the build-from-this-repo Automated Build (I've done this previously for OpenResty). Another alternative is to publish it under |
I have never done anything with Docker before. I have no idea how many people are waiting for a docker image of phpRedisAdmin and if it's worth the effort. |
Docker usage is quite on the rise nowadays and lots of people who want to use any piece of software often start by looking if it is available as a Docker image. Also, with a small effort a new no-frills (just Docker) distribution/packaging method is added. And also eases onboarding to Docker-aware devs, too. |
@erikdubbelboer ping |
I created https://hub.docker.com/r/erikdubbelboer/phpredisadmin/ |
Hi @erikdubbelboer. Sorry for the delay into getting back to you, I missed your answer notification. My apologies. Thanks for the patience and effort in setting everything up. The Docker Hub's AB repo looks good, but since you created it, an automatic 'map git tags & branches to Docker image tags' feature has been made available. Since I see a '1.8.0' but no matching '1.9.0' image tag on Hub, you might want to take a look to the image build configuration options: https://hub.docker.com/r/erikdubbelboer/phpredisadmin/~/settings/automated-builds/ Also, either contacting the https://hub.docker.com/r/phpredisadmin/phpredisadmin/ user owner via support helpdesk to transfer the username ownership (I've done it already for OpenResty) or warning about it not being official someway in the docs might be in order, if you feel like it. Anyway, the docs already point to your user's image. |
I have changed the automated build to what you said but instead of Branch I chose Tag as I don't use branches for releases but only tags. As for contacting https://hub.docker.com/r/phpredisadmin/phpredisadmin/ how would I do this? I don't see any contact information or even any way to report this to docker without starting to pay for support. |
I'm not sure if you can restrict image building to only tags the way you've done, never done it myself. If you're sure to have pushed the tag after setting this up that way, maybe it's not supposed to work that way. And for the user name, I was just suggesting to contact Docker Hub's support helpdesk, since I'm aware of no public contact method. I did it in the past to recover the unused 'openresty' user that way (see openresty/docker-openresty#4). But it's not a hard requirement, just trying to get the most obvious user name and avoid people getting confused by the wrong image if googling. |
I'm sorry but that docker build system seems completely broken. I tried all kinds of settings now and none work. Builds never automatically trigger and the Tigger only seems to be available for the master branch. I'm not going to bother spending time on a broken system anymore. I'll just have to remember to press that button each time I push something I guess :( |
It's not the best UX out there, but it's not broken, though. :) If you want to have a 1.10 image tag, just temporarily add a specific, one-time, explicit configuration row and use it to push its 'Trigger' button. Delete it afterwards and leave everything as suggested to let it work automagically from now on. |
I changed it to exactly as your screenshot says. I just pushed version 1.10.1 to test this. But it doesn't seem to trigger any build so far. What is your username on docker so I can add you as collaborator. I manually did 1.10.0 as you said and at least that worked :) |
Ops, that doesn't sounds good :S |
I have added you as collaborator. You can have a look at the settings, let me know if you want me to push a new version so you can test them. |
@erikdubbelboer : I see no extra settings or configuration screen thru which I can help you on Docker Hub :( Neither on Github, which I also checked, just in case. |
I have recreated the repository and added you as collaborator again. I have only clicked the Trigger button to have a least one build. I don’t dare to do anything else! |
Checked and confirmed. However, according to https://docs.docker.com/docker-hub/repos/ looks like collaborators aren't too useful, compared to orgs. I would leave it as is now and see how it goes next time you push a new tag. |
How to test:
After these, browse to http://localhost
If merged, I can help with either:
With any of these, an 'automated build' can be set up on Docker Hub that will trigger an image rebuild on each Github commit.