-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to override variables in SASS version #95
Comments
This is specific to Sass and not Less? This is my first go with Sass and not less. I will look in to this, but also feel free to PR. From: Valentyn notifications@github.com Hey, guys! I needed to override the path to fonts directory and found a variable in sources - $wi-path (here). I've tried to override it before importing the main SCSS file of the package but failed. Then I've looked carefully again and found out that it can not be overridden due to missing !default after its value. This applies to all those variables next to $wi-path. I can submit a PR. — |
Yes, this is specific to SASS. This is one of my first projects with SASS and I just ran into a fact that variables are loading in different way in it. In LESS you can do overrides anywhere, but in SASS you need to add |
Also here, "Variable Handling" section. |
Looks nice! It would be also cool if you bump the package version so the fix will be available over package managers. Thank you. |
Would that require adding a new tag and pointing the bower file there? I still don't quite grasp the package manager management. |
I guess so. And you need to update version (to 2.0.2, I think, as it is a fix). |
Good! |
Hey, guys!
I needed to override the path to fonts directory and found a variable in sources -
$wi-path
(here). I've tried to override it before importing the main SCSS file of the package but failed. Then I've looked carefully again and found out that it can not be overridden due to missing!default
after its value. This applies to all those variables next to$wi-path
. I can submit a PR.The text was updated successfully, but these errors were encountered: