fix expansion of the $hosts variable #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if value of $hosts contains spaces, which can be defined by br -m "host1 host2", bash will expand it as is. So "if [ -z $hosts ]" is expanded to "if [ -z host1 host2 ]", this is wrong. This commit add quotes to the $hosts variable, so it is expanded correctly. Signed-off-by: Zhou Zheng Sheng <zhshzhou@linux.vnet.ibm.com>
|
Good catch, thanks! |
erikfrey
added a commit
that referenced
this pull request
Jan 2, 2013
fix expansion of the $hosts variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if value of $hosts contains spaces, which can be defined by
br -m "host1 host2", bash will expand it as is. So
"if [ -z $hosts ]" is expanded to "if [ -z host1 host2 ]", this is
wrong. This commit add quotes to the $hosts variable, so it is expanded
correctly.
Signed-off-by: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com