Escape path strings to avoid tripping up the regex #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents tmp directories like "/var/folders/TT/TTeZp5JaF4y7rWPBqCM44U+++TI/-Tmp-/HcLtmr36-K3cA-F9vK-1FGl-hTrvaUr1BISG" from causing RegexpError exceptions like "nested *?+ in regexp: /^\/var\/folders\/TT\/TTeZp5JaF4y7rWPBqCM44U+++TI\/-Tmp-\/HcLtmr36-K3cA-F9vK-1FGl-hTrvaUr1BISG/"
|
And to dispel possible confusion, the escaped forward-slashes in the output were from Ruby's output, not the actual content of the string. |
sferik
added a commit
that referenced
this pull request
Jun 21, 2012
Escape path strings to avoid tripping up the regex
|
ECOMMON bros, this pull request should have tests. I have pushed a test and a similar fix (which matches the regexp just once). |
|
Sorry bro, my fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents tmp directories like "/var/folders/TT/TTeZp5JaF4y7rWPBqCM44U+++TI/-Tmp-/HcLtmr36-K3cA-F9vK-1FGl-hTrvaUr1BISG" from causing RegexpError exceptions like "nested *?+ in regexp: /^/var/folders/TT/TTeZp5JaF4y7rWPBqCM44U+++TI/-Tmp-/HcLtmr36-K3cA-F9vK-1FGl-hTrvaUr1BISG/"