Negative options #460
Merged
Negative options #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 An option's default must match its type error in master |
| @@ -86,7 +86,7 @@ def usage(padding = 0) | |||
| sample = "[#{sample}]" unless required? | |||
|
|
|||
| if boolean? | |||
| sample << ", [#{dasherize("no-" + human_name)}]" unless name == "force" | |||
| sample << ", [#{dasherize("no-" + human_name)}]" unless name == "force" or name.start_with?("no") | |||
There was a problem hiding this comment.
I believe this line would prevent the automatic negation of all options that that start with "no", even if they are not negative options?
For example, what if there was an boolean --nougat option. I believe this would prevent the generation of a --no-nougat option.
There was a problem hiding this comment.
Good catch. I fixed it and also added a test case for "--nougat" to make sure there will never be a regression :)
…boolean options (--no-foo)
|
Thanks! |
tommarshall
added a commit
to tommarshall/thor
that referenced
this pull request
Mar 7, 2017
Because: * rails#460 (released in `0.19.2`) introduced a change that prevents double negative options (`--no-no-foo`) for already negative boolean options (`--no-foo`). * That change checks if the option name string starts with 'no-', before it's `dasherized`, therefore negative options defined with underscores (`:no_foo`) still generate a double negative `--no-no-foo` option.
tommarshall
added a commit
to tommarshall/thor
that referenced
this pull request
Mar 7, 2017
Because: * rails#460 (released in `0.19.2`) introduced a change that prevents double negative options (`--no-no-foo`) for already negative boolean options (`--no-foo`). * That change checks if the option name string starts with 'no-', before it's `dasherized`, therefore negative options defined with underscores (`:no_foo`) still generate a double negative `--no-no-foo` option. This change: * Adds a test for, and fixes the double negative boolean options defined with underscores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not generate a negative option (--no-no-foo) for already negative boolean options (--no-foo)