Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android support #3

Open
sibelius opened this issue Jan 4, 2018 · 5 comments
Open

android support #3

sibelius opened this issue Jan 4, 2018 · 5 comments

Comments

@sibelius
Copy link
Contributor

sibelius commented Jan 4, 2018

No description provided.

@erikpoort
Copy link
Owner

Do you mean that for android I should launch an intent that opens the pass with a shoebox urlscheme?

@sibelius
Copy link
Contributor Author

sibelius commented Jan 4, 2018

not sure yet

erikpoort pushed a commit that referenced this issue Jan 5, 2018
Start on Android implementatio of Wallet
419d546 
Android has certain apps that can handle your Apple Wallet Passes. I
found out that the approach I took in this commit, will never work, as I
misunderstood what the shoebox urlscheme does on iOS. It will open Apple
Pay, it's not something they use in PassKit to add passes. I figured
this out when I installed a few of those Android apps and they didn't
really care about my urlscheme. When I removed the code that changes the
uri's scheme to shoebox and the browser offered me to download the
pkpass file for me. All the Android apps were able to add the pkpass.

Next step will be to try and download the file in a Downloads folder and
offer an intent to any app that says it can handle the file.

Re #3
@clevertree
Copy link

@erikpoort Nice library! Question,

Would it make sense for this library to integrate the new Google Pay (GPay) SDK to support android? I'm confused on a few points, but I'm assuming GPay has the same functionality as Apple Wallet in regards to this library.

I would like to help develop this add-on if possible. Any advice for someone who has not created a react-native library before? I'm assuming it all comes down to exporting the necessary endpoints and testing. Thanks!

@erikpoort
Copy link
Owner

I'm not really up to date on Android development, so I wouldn't be able to tell you whether or not it has the same functionalities.

If you want to add this functionality to the lib, you can send me a PR. Check out some of my other repositories to get an idea on how I like the setup to be done :)

@david-plastiq
Copy link

@erikpoort Nice library! Question,

Would it make sense for this library to integrate the new Google Pay (GPay) SDK to support android? I'm confused on a few points, but I'm assuming GPay has the same functionality as Apple Wallet in regards to this library.

I would like to help develop this add-on if possible. Any advice for someone who has not created a react-native library before? I'm assuming it all comes down to exporting the necessary endpoints and testing. Thanks!

Did you find a GPay version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clevertree @sibelius @erikpoort @david-plastiq