Another hot module reloading attempt #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| "engines": { | ||
| "node": ">=0.10.32" | ||
| "node": ">=2.2.1" |
There was a problem hiding this comment.
Hmm, I thought one of the new dependencies required this version :/ My bad, I've force pushed a fix.
stevoland
force-pushed
the
hot-reload
branch
3 times, most recently
from
bcb0f61
to
a88045a
Compare
Hot loading remains in a separate process to allow server reloading Also unifies babel configs in .babelrc
stevoland
force-pushed
the
hot-reload
branch
from
a88045a
to
91cfa1e
Compare
|
Works for me! |
|
Excellent work, @stevoland!! 👍 🍻 |
|
cheers! 🎉 |
|
FYI when you'll be upgrading to react-transform-hmr there will be an error in the console |
waskito
pushed a commit
to waskito/react-redux-universal-hot-example
that referenced
this pull request
May 23, 2017
* createApp method instead of app in app.js (erikras#192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at #157 but keeps the dev server in it's own process to keep server reloading as per glenjamin's suggestion: #157 (comment).
I think this PR also consolidates babel configs in
.babelrcas per #53