chore(allTheThings): update to universal-redux npm module (react-router 2, redux-simple-router, babel 6) #759
Conversation
…eed them here now
…ot having access to bootstrap
… font awesome libs
|
@quicksnap sure, and i'll update that now. |
bdefore
changed the title
bdefore
changed the title
…to auth cookie so login will not work
|
Any chance of getting this merged in ? |
|
@andreijs at this point there's about a month of commits that would need to be brought in. also the api client's use of cookies would need to happen through a different manner, probably an express middleware change to put the cookie in the header. |
|
|
||
| var babelrc = fs.readFileSync('./.babelrc'); | ||
| var babelrc = fs.readFileSync(path.resolve(__dirname, 'node_modules/universal-redux/.babelrc')); |
There was a problem hiding this comment.
Is this ok? relaying on a node_modules .babelrc
There was a problem hiding this comment.
@andresgutgon while it doesn't feel great to explicitly reach into node_modules, it allows universal-redux projects to work without having a project level .babelrc. ideally this server.babel.js file wouldn't be used at all, as it's only used to allow es6 files to be transpiled on the fly.
There was a problem hiding this comment.
I don't know. It doesn't feel right to me. Could not be posible do it in another way?
What's the problem with having .babelrc here, in this project. And another .babelrc in universal-redux module?
Sorry, I just want to understand it
There was a problem hiding this comment.
Good question. The reason this file exists is so that this project can have ES6 in its server files and have transpilation on the fly. I think you're right that for the purpose of this project a .babelrc should live on project root, be configured in this file, and then be passed in through the universal-redux.config.js (via babelConfig) rather than reaching into node_modules, that way the internal concerns of universal-redux (such as react-transform-hmr configuration) don't leak into the project .babelrc configuration.
There was a problem hiding this comment.
Thanks @bdefore
Again, great work 💪
|
Really great work! 👍 |
|
Thanks for your effort! |
|
exciting! |
|
A fresh PR and migration is probably in order in case anyone would like to use UR since merging in #833. Good news is that those changes bring the two projects closer together implementation wise. Bad news is that I'm not sure when I'll be able to get around to making a new PR. |
|
@bdefore looking forward to it whenever you get around to it! :) |
The
universal-reduxnpm package bumped to 3.0.0-beta1 with React Router 2 support. There are some regressions but expect to clean them up shortly: bdefore/universal-redux#24This is a monster PR now, sorry about the huge diff. It's a descendant of #626 (npm package) #685 (redux-simple-router) and #730 (babel 6). I thought I would drop the latest here in case anyone else is considering updating to RR2 themselves; the diff at the issue above might be instructional for porting.