New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lodash.noop Should Be a Dependency #23

Closed

timscott opened this issue Aug 2, 2016 · 2 comments

timscott commented Aug 2, 2016

I believe this is a bug:
https://github.com/erikras/redux-form-material-ui/blob/master/package.json#L56

It should be in dependencies, not devDependencies since it's imported here:

redux-form-material-ui/src/AutoComplete.js

Line 2 in c485bb7

import noop from 'lodash.noop'

erikras added a commit that referenced this issue


          fixed lodash dep problem #23, v4.0.1

842b2f6

Owner

erikras commented Aug 2, 2016

Doh. It just shouldn't have been used there.

Owner

erikras commented Aug 2, 2016

Fixed in v4.0.1.

erikras closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment